-
Notifications
You must be signed in to change notification settings - Fork 676
Add rocky linux support to GetOSVersion #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @sudheernv! |
Hi @sudheernv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Wondering if we should just default to getDebianVersion
if the OS is not COS.
Your new unit test is failing. |
a5edc5f
to
7ee2a4d
Compare
Sorry @mmiranda96. Yesterday, I inadvertently omitted pushing the commit that contained the correct expected string for the newly introduced test case. Pushed new commit with necessary fix now. -- expectedOSVersion: "8.5 (Green Obsidian)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sudheernv, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue: Node Problem Detector fails to come up on rocky linux OS.
Error Log: Failed to retrieve OS version: Unsupported ID in /etc/os-release: "rocky"