Skip to content

KEP-5142: Add SchedulerPopFromBackoffQ feature gate docs #49840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

KEP-5142: Add SchedulerPopFromBackoffQ feature gate docs #49840

merged 1 commit into from
Apr 8, 2025

Conversation

macsko
Copy link
Member

@macsko macsko commented Feb 19, 2025

Description

Add SchedulerPopFromBackoffQ feature gate to docs.

Issue

kubernetes/enhancements/issues/5142

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit df1389a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67b5e791cab84c00082956e3

@macsko macsko mentioned this pull request Feb 19, 2025
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit df1389a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b5e7918a139d0008029b41
😎 Deploy Preview https://deploy-preview-49840--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@macsko macsko marked this pull request as ready for review March 21, 2025 13:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@rayandas
Copy link
Member

rayandas commented Apr 4, 2025

Hello @macsko 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@macsko
Copy link
Member Author

macsko commented Apr 7, 2025

@dipesh-rawat @katcosgrove I need a review before the docs freeze

tengqm
tengqm reviewed Apr 7, 2025
View reviewed changes
...ent/en/docs/reference/command-line-tools-reference/feature-gates/SchedulerPopFromBackoffQ.md
---

Improves scheduling queue behavior by popping pods from the backoffQ when the activeQ is empty.
This allows to process potentially schedulable pods ASAP, eliminating a penalty effect of the backoff queue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the gate for all kube-components, or is it only relevant to the scheduler?

My guess is that this is only relevant to the scheduler.
If this option is only for the kube-scheduler, why do we make it a feature gate (for cross-cutting features involving more than one component)?
Can we simply use the kube-scheduler config file for this?
Feature gates are "heavy switchces".
With no explicit documentation on which gates involve which component, a cluster operator may have to restart all kubelets and even kube-proxy on all nodes.
/hold

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a feature gate only for the kube-scheduler. There are also other feature flags for another enhancements that similarly are designed only for a kube-scheduler. I'm not sure if moving from a feature gate to the config file is a good idea given that we are in the enhancements and code freezes.

How can an explicit documentation look like?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
This issue has been sent to sig-architecture for guidance. I'm not anticipating a decision before the deadline this time, so I'm lifting the hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2025
@tengqm tengqm added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. committee/steering Denotes an issue or PR intended to be handled by the steering committee. labels Apr 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Apr 7, 2025
@rayandas
Copy link
Member

rayandas commented Apr 7, 2025

@macsko This PR also require a technical review. Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2025
@tengqm tengqm removed the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Apr 7, 2025
@macsko
Copy link
Member Author

macsko commented Apr 8, 2025 •
edited
Loading

/cc @dom4ha @sanposhiho
For SIG Scheduling review

sanposhiho
sanposhiho approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

from sig-scheduling.

I'm feeling like we should add a simple doc page to describe the queue's architecture.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8168754dafa5c88094960b4613ed12d9e952105c

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

@tengqm Need a Docs approval. Thanks!

@tengqm
Copy link
Contributor

tengqm commented Apr 8, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit ca59526 into kubernetes:dev-1.33 Apr 8, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Scheduling Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@reylejano reylejano Awaiting requested review from reylejano

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@Princesso Princesso Awaiting requested review from Princesso

@dom4ha dom4ha Awaiting requested review from dom4ha

+1 more reviewer

@sanposhiho sanposhiho sanposhiho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macsko @rayandas @k8s-ci-robot @tengqm @sanposhiho