add doc for special note for hpa #5313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Collaborator
|
Deploy preview ready! Built with commit f520d39 https://deploy-preview-5313--kubernetes-io-master-staging.netlify.com |
resouer
reviewed
Sep 6, 2017
| in a replication controller, deployment or replica set based on observed CPU utilization | ||
| (or, with alpha support, on some other, application-provided metrics). | ||
| (or, with alpha support, on some other, application-provided metrics). Note that Horizontal | ||
| Pod Autoscaling does not support object that can't be scaled like DaemonSet. |
Contributor
There was a problem hiding this comment.
maybe: ... Pod Autoscaling does not apply to objects that can't be scaled, for example, DaemonSet.
Contributor
Author
|
Thanks for the review, @resouer changed according to your suggestion PTAL. |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sentence in the hpa doc to explicitly specify that hpa doesn't support daemonset to fix kubernetes/kubernetes#48588
This change is