Skip to content

Conversation

@kulp
Copy link
Owner

@kulp kulp commented Sep 15, 2020

Using absolute paths has always been something of a workaround, but it particularly causes problems for NODERAWFS, which we would like to use.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #62 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #62     +/-   ##
=========================================
- Coverage     89.1%   89.0%   -0.2%     
=========================================
  Files           34      34             
  Lines         2699    2699             
  Branches       482     482             
=========================================
- Hits          2407    2404      -3     
  Misses         137     137             
- Partials       155     158      +3     
Impacted Files Coverage Δ
src/common.h 100.0% <ø> (ø)
src/devices/sdlvga.c 78.0% <0.0%> (-2.2%) ⬇️
src/devices/sdlled.c 81.1% <0.0%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3787408...54925a1. Read the comment docs.

@kulp kulp marked this pull request as ready for review September 15, 2020 03:43
@kulp kulp merged commit 821f329 into develop Sep 18, 2020
@kulp kulp deleted the reduce-abspath branch September 18, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants