Skip to content

Conversation

@rmfaheem
Copy link
Contributor

@rmfaheem rmfaheem commented Apr 7, 2021

Bumped version of Microsoft Sourcelink package used by ClientAPI to 1.0.0. Was previously 1.0.0-beta-63127-02.

The previous version was causing build to fail on Ubuntu 18+. The issue had been patched in nuget package a while ago.

Relevant PR on sourcelink repo: #288.

Related issue on ES docs with workaround: #361

Other related issues:

Copy link
Contributor

@hayley-jean hayley-jean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine on my side after the fix, thanks @rmfaheem !

@shaan1337 shaan1337 merged commit ee394c9 into v5-master Apr 8, 2021
@shaan1337 shaan1337 deleted the v5-sourcelink-update branch April 8, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants