fix: ctx must be supplied to LogErrorAndReturn()#164
Merged
kyma-bot merged 1 commit intokyma-project:mainfrom Mar 27, 2024
Merged
fix: ctx must be supplied to LogErrorAndReturn()#164kyma-bot merged 1 commit intokyma-project:mainfrom
kyma-bot merged 1 commit intokyma-project:mainfrom
Conversation
kyma-bot
added
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
ctxmust be supplied to LogErrorAndReturn() otherwise whole loggining context is lost and not logged, like controller, group, kind, resource name, and everything else put into it that's helping going trough logs and tracing a single reconcilation loopRelated issue(s)