Skip to content

feat(AwsNfsVolume): add finalizer to PV and PVC#291

Merged
kyma-bot merged 2 commits intokyma-project:mainfrom
dushanpantic:add-finalizers-to-aws-pv-and-pvc
Jun 14, 2024
Merged

feat(AwsNfsVolume): add finalizer to PV and PVC#291
kyma-bot merged 2 commits intokyma-project:mainfrom
dushanpantic:add-finalizers-to-aws-pv-and-pvc

Conversation

@dushanpantic
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adds finalizer to PV that is created for AwsNfsVolume
  • Adds mechanism to remove said PV finalizer when AwsNfsVolume is beign deleted
  • Adds finalizer to PVC that is created for AwsNfsVolume
  • Adds mechanism to remove said PVC finalizer when AwsNfsVolume is beign deleted

Related issue(s)

@dushanpantic dushanpantic requested a review from a team as a code owner June 14, 2024 11:54
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
ijovovic
ijovovic previously approved these changes Jun 14, 2024
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 14, 2024
@dushanpantic dushanpantic marked this pull request as draft June 14, 2024 12:07
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 14, 2024
@dushanpantic dushanpantic marked this pull request as ready for review June 14, 2024 12:09
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@dushanpantic dushanpantic requested a review from ijovovic June 14, 2024 12:09
Copy link
Contributor

@ijovovic ijovovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 14, 2024
@kyma-bot kyma-bot merged commit b54455a into kyma-project:main Jun 14, 2024
@dushanpantic dushanpantic deleted the add-finalizers-to-aws-pv-and-pvc branch June 14, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants