Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tests
  • Loading branch information
mluk-sap committed Nov 19, 2025
commit fda96e08f0be071d4ded3f98eb70c9b021fd88f6
4 changes: 2 additions & 2 deletions controllers/validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

var _ = Describe("Istio Controller", func() {
It("should set CR status to warning if experimental fields have been defined", func() {
It("should set CR status to error if experimental fields have been defined", func() {
// given
istioCR := &operatorv1alpha2.Istio{
ObjectMeta: metav1.ObjectMeta{
Expand Down Expand Up @@ -70,7 +70,7 @@ var _ = Describe("Istio Controller", func() {
err = fakeClient.Get(context.Background(), client.ObjectKeyFromObject(istioCR), &updatedIstioCR)
Expect(err).To(Not(HaveOccurred()))

Expect(updatedIstioCR.Status.State).Should(Equal(operatorv1alpha2.Warning))
Expect(updatedIstioCR.Status.State).Should(Equal(operatorv1alpha2.Error))
Expect(updatedIstioCR.Status.Description).To(ContainSubstring("Experimental features are not supported in this image flavour"))
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
#[...]
```

The experimental features should be only available to be used with a separately built controller image. Using the experimental features with production image should result in setting the Istio rustom resource to the `Warning` state.
The experimental features should be only available to be used with a separately built controller image. Using the experimental features with production image should result in setting the Istio custom resource to the `Error` state and break the reconciliation to avoid unintended changes.

### SAP BTP, Kyma Runtime
In context of SAP BTP, Kyma runtime, experimental features should only be available in the experimental release channel.
Expand Down
Loading