Skip to content

Custom private registry based on env #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Custom private registry based on env #1702

wants to merge 2 commits into from

Conversation

@werdes72
Copy link
Contributor

@werdes72 werdes72 commented Nov 19, 2025 •
edited
Loading

Description

Allow usage of private registry for Istio images. Set imagePullSecrets in Istio operator based on SKR_IMG_PULL_SECRET environment variable.

Additional secret example:

kubectl -n istio-system create secret docker-registry regcred \
  --docker-server=registry.example.com \
  --docker-username=USER \
  --docker-password='PASSWORD'

Related Issue
#1691

@werdes72 werdes72 requested a review from a team as a code owner November 19, 2025 09:15
@werdes72 werdes72 changed the title Custom private registry example with pull secrets Custom private registry based on env Nov 20, 2025
barchw
barchw requested changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@barchw barchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests and LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barchw barchw barchw requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@werdes72 @barchw