Add support for pod status.phase field selector in fake client #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/M
triffer
requested review from
barchw,
cnvergence,
dariusztutaj,
strekm,
videlov and
werdes72
as code owners
cnvergence
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently some of the tests fail. We didn't have a test job configured for this repo when this was introduced, so we didn't see it.
The tests were failing since the update of sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.0 (#46).
The root cause why tests are failing is, that a support for indexes was introduced to the fake client (kubernetes-sigs/controller-runtime#2025). Before the field selectors were just ignored. After adding the change in the fake client field selectors unknown to the fake client will cause an error.
Changes proposed in this pull request:
Related issue(s)