Skip to content

Conversation

@danopia
Copy link
Contributor

@danopia danopia commented Jul 4, 2018

  • Add support for spaces in www-form-urlencoded bodies, by replacing + with spaces before decoding
    • My understanding is that a real + gets encoded as %2B and won't be impacted
  • Add support for zero-length bodies, by skipping body reading, and passing a zero-length buffer through instead
    • Only when Content-Length is sent to begin with. Otherwise current behavior is kept.

Both changes tested by submitting <form method="post"> bodies from Chrome.

@kzahel
Copy link
Owner

kzahel commented Jul 9, 2018

Thank you for the fixes.

@kzahel kzahel merged commit f7bdc4c into kzahel:master Jul 9, 2018
@danopia
Copy link
Contributor Author

danopia commented Jul 9, 2018

Thank you for this software - my project would be so much harder if I had to write a whole http stack too! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants