Conversation
|
Hi, thanks for the PR and glad to hear you’re finding the project useful!
I have a few questions as someone who has no prior experience with Nix:
Yes, that's fine with me. |
|
Thanks for the feedback!
|
shell.nix
Outdated
|
|
||
| buildInputs = with pkgs; [ | ||
| # Node tooling | ||
| nodejs_20 |
There was a problem hiding this comment.
It would be better to use the latest Node LTS release (24) if possible.
|
Appreciate your insight, thank you for the thorough explanations! I’m fine with moving forward with this, just have a minor nit that I’ve added to the review above. |
|
I improved the nix shell a bit, turns out I can leave out most of the dependencies. Copied them from another project, but that is apparently more complex in its setup. Updating to node 24 worked fine, just a few additions to the package lock. I also added a small section on nix-direnv to the development section of the readme. |
|
Everything looks good to me. Thanks again for the contribution! |
Thanks for the awesome project! I was really struggling with setting up mo2 or vortex on linux, but this worked flawlessly.
I made some changes to get this to build on nixos, but I think they are not interfering with other operating systems, so I wanted to contribute my work on this.
My nixos dev flow is based on direnv and nix-direnv. When entering the projectfolder via terminal, nix-direnv is called via the .envrc and the shell.nix is evaluated, dependencies are grabbed and set up, and
npm run startshould succeed straight away.wI'll draft a nix derivation to publish the mod loader to nixpkgs so its available to install via nix and on nixos if that's alright with you.