PHP8 Support #13
Closed
PHP8 Support #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javabudd
force-pushed
the
php8
branch
3 times, most recently
from
d4435c3 to
5fb7fb2
Compare
Signed-off-by: andyo <[email protected]> Add php 7.3, 7.4, and 8.0 matrices, remove < 7.3 Signed-off-by: andyo <[email protected]> Add return types Signed-off-by: andyo <[email protected]> Use php 8 explicitly Signed-off-by: andyo <[email protected]> Clean up confusing class logic and ambiguous code Signed-off-by: andyo <[email protected]> Clean up doc blocks, add matching __set/__isset methods Signed-off-by: andyo <[email protected]> call new method Signed-off-by: andyo <[email protected]> call new method Signed-off-by: andyo <[email protected]> Update assertion calls Signed-off-by: andyo <[email protected]> update assert contains using string Signed-off-by: andyo <[email protected]> Implement ConfigProviderInterface and minor code cleanup Signed-off-by: andyo <[email protected]> Update string not contains assertions Signed-off-by: andyo <[email protected]> Fix method name Signed-off-by: andyo <[email protected]> require laminas/laminas-modulemanager Signed-off-by: andyo <[email protected]> Implement BootstrapListenerInterface Signed-off-by: andyo <[email protected]> Update onBootstrap signature to match interface Signed-off-by: andyo <[email protected]> Add return types Signed-off-by: andyo <[email protected]> Update ruleset path Signed-off-by: andyo <[email protected]> Fix rule path Signed-off-by: andyo <[email protected]> revert eventmanager constraint change Signed-off-by: andyo <[email protected]> Migrate phpunit.xml.dist schema Signed-off-by: andyo <[email protected]> use prophecy trait Signed-off-by: andyo <[email protected]> Update laminas/view to 2.11.3 and add phpspec/prophecy-phpunit to require-dev Signed-off-by: andyo <[email protected]> Clean up tests Signed-off-by: andyo <[email protected]> Revert set logic Signed-off-by: andyo <[email protected]> use ::class Signed-off-by: andyo <[email protected]> throw exception in default case Signed-off-by: andyo <[email protected]> Remove senseless breaks Signed-off-by: andyo <[email protected]> Add ApplicationInterface docblocks Signed-off-by: andyo <[email protected]> Add return types. Add JSON_THROW_ON_ERROR to jsonFlags Signed-off-by: andyo <[email protected]> Add phpunit result cache to .gitignore Signed-off-by: andyo <[email protected]> Add return types. Cleanup code. Signed-off-by: andyo <[email protected]> Variable alignment Signed-off-by: andyo <[email protected]> Revert setter changes Signed-off-by: andyo <[email protected]> Revert setter changes Signed-off-by: andyo <[email protected]> Add return types and minor code cleanup Signed-off-by: andyo <[email protected]> Add return types and minor code cleanup Signed-off-by: andyo <[email protected]> revert logic Signed-off-by: andyo <[email protected]> Implement FactoryInterface Signed-off-by: andyo <[email protected]> remove modulemanager Signed-off-by: andyo <[email protected]> revert formatting Signed-off-by: andyo <[email protected]> Add modulemanager to require-dev Signed-off-by: andyo <[email protected]>
Closed
6 tasks
Signed-off-by: andyo <[email protected]>
Signed-off-by: andyo <[email protected]>
Signed-off-by: andyo <[email protected]>
Signed-off-by: andyo <[email protected]>
javabudd
commented
Mar 2, 2021
| $normalized = strtolower($name); | ||
| if (in_array($normalized, array_keys($this->normalizedProperties))) { | ||
| $normalized = \strtolower($name); | ||
| if (\array_key_exists($normalized, $this->normalizedProperties)) { |
javabudd
commented
Mar 2, 2021
| } | ||
|
|
||
| return 'Unknown Error'; | ||
| return $this->recommendedReasonPhrases[$this->statusCode] ?? 'Unknown Error'; |
javabudd
commented
Mar 2, 2021
| 100 | ||
| ); | ||
|
|
||
| if ($sharedEvents) { |
Author
There was a problem hiding this comment.
ensures shared event manager is setup before calling attach on it
javabudd
commented
Mar 2, 2021
| foreach ($this->acceptFilters as $type) { | ||
| $match = $accept->match($type); | ||
| if ($match && $match->getTypeString() != '*/*') { | ||
| if ($match && $match->getTypeString() !== '*/*') { |
javabudd
commented
Mar 2, 2021
| * @return array | ||
| */ | ||
| public function toArray() | ||
| public function __set(string $name, $value) |
Author
There was a problem hiding this comment.
__set and __isset satisfy magic requirements
javabudd
commented
Mar 2, 2021
| protected function getDetail() | ||
| { | ||
| if ($this->detail instanceof Throwable || $this->detail instanceof Exception) { | ||
| if ($this->detail instanceof Throwable) { |
Author
There was a problem hiding this comment.
since we support only 7.3 and above, remove redundant instanceof Exception conditions
Contributor
|
Closing in favor of #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #12 and targets the 1.4.x branch.
Issues with required libraries: