Remove dependency on real storage adapters and therefore benchmarks#272
Merged
Conversation
This also removes benchmarks which are so available in each adapter repository and thus were redundant. Even tho, we are now unable to directly see impact on performance when changing `AbstractAdapter`, the adapters themselves keep track on performance due to renovate updating locks permanently. Longterm, the `AbstractAdapter` will most likely be removed in favor of cache backend specific features explicitly implemented. The `StorageInterface` will extend the PSR interfaces and requires the adapters to serve these interfaces in their own way. Therefore, removing benchmarks might be a good thing since the `StorageInterface` is meant to be feature complete. With laminas#130, some methods might be removed from the `StorageInterface` but extending that interface is not planned. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
qa/remove-benchmarks
branch
from
f1d1c78 to
2fbcaa3
Compare
Member
Author
|
@Ocramius I'd love to get your two cents on this. Esp. the benchmark and integration test stuff. |
This was referenced Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the past, we had several problems providing proper support, i.e. for APCu on new PHP versions, etc.
IMHO, there were too many integration tests inside this repository which was kinda helpful when developing within the PSR decorators but on the other side, introduced circular dependencies which was especially annoying when working on new major versions (like as we do right now).
This also removes benchmarks which are so available in each adapter repository and thus were redundant.
Even tho, we are now unable to directly see impact on performance when changing
AbstractAdapter, the adapters themselves keep track on performance due to renovate updating locks permanently.Longterm, the
AbstractAdapterwill most likely be removed in favor of cache backend specific features explicitly implemented in the storage adapters directly (which is already done in some of the adapters anyways). TheStorageInterfacewill extend the PSR interfaces and requires the adapters to serve these interfaces in their own way. Therefore, removing benchmarks might be a good thing since theStorageInterfaceis meant to be feature complete.With #130, some methods might be removed from the
StorageInterfacebut extending that interface is not planned.