feat: improve do_write_fragments concurrency#5605
Open
lichuang wants to merge 1 commit intolance-format:mainfrom
Open
feat: improve do_write_fragments concurrency#5605lichuang wants to merge 1 commit intolance-format:mainfrom
lichuang wants to merge 1 commit intolance-format:mainfrom
Conversation
f4c261c to
84c36f8
Compare
Contributor
|
Hi @lichuang. This PR is interesting. I was thinking about doing something similar soon. However, one drawback to doing this as written is if you have a small stream of data, then you can end up writing several small files, which is sub-optimal. There's no way to know just from a stream how big it is. But if the input is materialized or otherwise provides information about how big the input is, then we can make smarter decisions about parallelization. That's why I wanted to implement #4583 first, before we implement a parallelized writer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The original
do_write_fragmentsfunction processed data sequentially:This sequential approach had several limitations:
Solution: Concurrent Multi-File Write
The optimized version (
do_write_fragments_concurrent) implements a parallel processing pipeline:Architecture
Key Components
MAX_CONCURRENT_WRITERS(default: 4) active file writers