feat(rust): support datafusion url table#5807
feat(rust): support datafusion url table#5807majin1102 wants to merge 6 commits intolance-format:mainfrom
Conversation
Code ReviewSummaryThis PR adds support for DataFusion URL table queries against Lance datasets (e.g., Potential IssuesP1: URL detection may be too simplistic The if !url.ends_with(".lance") {
return Ok(None);
}This could have edge cases:
Consider using URL parsing or path extraction before checking the extension, or document these limitations. P1: Missing license header line
Minor Observations
Overall the implementation follows the existing patterns in the codebase well. |
fe3846c to
d13da84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@wjones127 @timsaucer |
Close #5806