ci: release fixes; add flag to always run full CI during release #10066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughWorkflow updates across CI, release, and Docker pipelines: introduce inputs.ref and run-all-tests in CI; normalize conditions using ${{ ... }} and always()/cancelled(); add lfx-tests in python_test; overhaul release.yml with new inputs (release_lfx, dry_run), dependency validation, and refactored job gating; upgrade Node.js to 22 across multiple workflows; adjust Docker build/tag logic and provenance. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant CI as CI Workflow
participant PF as Path Filter
participant Jobs as Test Jobs
Dev->>GH: Trigger CI (workflow_dispatch/workflow_call)\ninputs: ref, run-all-tests
GH->>CI: Start workflow
CI->>CI: echo-inputs (print ref, run-all-tests)
CI->>PF: Evaluate should-run-ci / should-run-tests
alt run-all-tests == true
CI->>Jobs: Run all test jobs (if not cancelled)
else path-based
PF-->>CI: Paths changed flags
CI->>Jobs: Conditionally run relevant test jobs
end
CI->>CI: ci_success step guarded by always() and not cancelled()
CI-->>GH: Report outcome
sequenceDiagram
autonumber
actor Rel as Release Trigger
participant GH as GitHub Actions
participant VTag as validate-tag
participant VDep as validate-dependencies
participant CI as ci (with inputs.ref, run-all-tests=true)
participant BBase as build-base
participant BMain as build-main
participant Pub as publish-main
participant RelJob as create_release
Rel->>GH: Trigger release.yml\ninputs: release_package_base/main, release_lfx, dry_run
GH->>VTag: Validate tag
GH->>VDep: Ensure main implies base
VTag-->>CI: ok
VDep-->>CI: ok
GH->>CI: Run CI (unconditional runs-on)
par Build
GH->>BBase: if release_package_base
GH->>BMain: if release_package_main
end
BMain-->>Pub: Build outputs (version, dist-main)
GH->>Pub: Publish if not dry_run and push_to_registry
Pub-->>RelJob: Publish success
alt not dry_run and success and not cancelled
GH->>RelJob: Create GitHub Release using BMain version and dist-main
else
GH-->>RelJob: Skip
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (47.20%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10066 +/- ##
==========================================
- Coverage 24.21% 24.21% -0.01%
==========================================
Files 1086 1086
Lines 40044 40067 +23
Branches 5541 5546 +5
==========================================
+ Hits 9696 9701 +5
- Misses 30177 30195 +18
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jordanrfrazier
changed the title
Collaborator
edwinjosechittilappilly
left a comment
edwinjosechittilappilly
left a comment
There was a problem hiding this comment.
All good. Need more eyes on ci.yml
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
This comment has been minimized.
This comment has been minimized.
|
Contributor
|
Build successful! ✅ |
Collaborator
Author
|
Need to skip reqs so I can get nightly fixed |
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly some dependency fixes and then adds a flag to ensure CI runs all tests during release processes.
Will add back the lfx stuff when ready for review
Summary by CodeRabbit
New Features
Tests
Release
Chores