Skip to content

fix: use issubclass in the pool creation #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cristhianzl merged 8 commits into from
Nov 17, 2025
Merged

fix: use issubclass in the pool creation #10232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83c5d1c
use issubclass in the pool creation
zzzming Oct 11, 2025
f804bdf
Merge branch 'main' into allowNullPool
HzaRashid Nov 17, 2025
75de3c9
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 17, 2025
0fa267d
add poolclass pytests
Cristhianzl Nov 17, 2025
59f5f98
Merge branch 'allowNullPool' of github.com:langflow-ai/langflow into …
Cristhianzl Nov 17, 2025
34a4860
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 17, 2025
01d9016
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] Nov 17, 2025
c964d50
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/backend/base/langflow/services/database/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,13 @@ def _create_engine(self) -> AsyncEngine:

poolclass_key = kwargs.get("poolclass")
if poolclass_key is not None:
pool_class = getattr(sa, poolclass_key, None)
if pool_class and isinstance(pool_class(), sa.pool.Pool):
pool_class = getattr(sa.pool, poolclass_key, None)
if pool_class and issubclass(pool_class, sa.pool.Pool):
logger.debug(f"Using poolclass: {poolclass_key}.")
kwargs["poolclass"] = pool_class
else:
logger.error(f"Invalid poolclass '{poolclass_key}' specified. Using default pool class.")
kwargs.pop("poolclass", None)

return create_async_engine(
self.database_url,
Expand Down