Skip to content

Conversation

@mendonk
Copy link
Collaborator

@mendonk mendonk commented Oct 30, 2025

Create two partials and add them where applicable.

  • Npx has to be installed in the Langflow docker container to run NPX commands.
  • Podman can be used in place of Docker. I didn't add this to the get-started/install page because it seemed like too much information too early.

Summary by CodeRabbit

  • Documentation
    • Added information about using Podman as an alternative to Docker for deployment commands.
    • Added Node.js LTS requirements and setup guidance for MCP server connections.
    • Enhanced documentation consistency and clarity across multiple guides.

@mendonk mendonk requested a review from aimurphy October 30, 2025 19:57
@mendonk mendonk self-assigned this Oct 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR refactors documentation by extracting reusable MDX partial components. Two new partial files are created containing tip content for MCP Node setup and Podman alternatives. Four existing documentation pages are updated to import and render these partials, replacing inline tip blocks with component references.

Changes

Cohort / File(s) Summary
MCP Documentation with Partial Components
docs/docs/Agents/mcp-client.mdx, docs/docs/Agents/mcp-component-astra.mdx
Added imports of PartialMcpNodeTip from the new partial file and replaced inline tip blocks with <PartialMcpNodeTip /> component references.
Deployment Documentation with Partial Components
docs/docs/Deployment/deployment-docker.mdx, docs/docs/Deployment/develop-application.mdx
Added imports of PartialPodmanAlt from the new partial file and rendered <PartialPodmanAlt /> components near the top of the pages.
New MDX Partial Files
docs/docs/_partial-mcp-node-tip.mdx, docs/docs/_partial-podman-alt.mdx
Created two new reusable MDX partial files: one containing a tip about UVX/UV availability and Node.js setup for MCP servers, and another containing guidance on using Podman as a Docker alternative.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes follow a consistent, repetitive refactoring pattern (extract content into partial, add import, replace with component reference)
  • All modifications are in documentation with no logic or code changes
  • New partial files are straightforward tip/informational content blocks

Possibly related PRs

Suggested labels

documentation, size:L, lgtm

Suggested reviewers

  • aimurphy
  • edwinjosechittilappilly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 3 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Test Quality And Coverage ❓ Inconclusive This pull request is exclusively focused on documentation changes—specifically adding two new MDX partial files (_partial-mcp-node-tip.mdx and _partial-podman-alt.mdx) and incorporating them into existing documentation pages. There are no code implementations, API endpoints, backend services, async functions, or any executable functionality being introduced. The custom check explicitly requires evaluation of test quality for "new implementations" and specifies testing patterns for backend (pytest), frontend (Playwright), and API endpoints. Since this PR contains only markdown and MDX documentation content with no executable code or functional features, the criteria for testing backend logic, async function patterns, and API endpoint validation do not apply. The check instructions are designed for code implementations and feature development that require unit and integration testing. Documentation-only pull requests, by their nature, do not require the type of testing specified in the check criteria. If this PR were implementing new features or APIs, those implementations should be tested according to the project's testing standards (pytest for backend, Playwright for frontend); however, documentation additions and refactoring do not fit this testing framework and should be evaluated based on documentation quality and link correctness instead.
Test File Naming And Structure ❓ Inconclusive This pull request is exclusively a documentation update with six MDX files—all located in the docs/ directory. The changes add two new partial MDX files (_partial-mcp-node-tip.mdx and _partial-podman-alt.mdx) and integrate them into four existing documentation pages. The shell script verification confirms that no files in this PR match any test file patterns (test_*.py, *.test.ts, *.test.tsx, or similar), meaning there are no test files to evaluate against the check criteria for naming, structure, coverage, or test organization. The "Test File Naming and Structure" check is designed to verify backend and frontend test files. Since this PR contains only documentation changes and no test files of any kind, the check criteria cannot be meaningfully applied. This check should either be skipped for documentation-only PRs or limited to PRs containing code changes in backend or frontend directories.
Excessive Mock Usage Warning ❓ Inconclusive The custom check "Excessive Mock Usage Warning" is designed to review test files for excessive use of mocks that may indicate poor test design. The pull request contains only six documentation files (.mdx), with no test files of any kind. The shell script analysis confirmed that there are no test files to review against the check criteria, making this check inapplicable to the current pull request.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "docs: add partials for npx requirements and podman" accurately captures the primary changes in the pull request. The changeset adds two new MDX partial files—one documenting npx/UVX requirements for running MCP servers and another describing Podman as a Docker alternative—and integrates them into multiple documentation pages. The title is concise, uses clear language with a standard "docs:" prefix, and specifically references both key components being introduced. A teammate reviewing the commit history would immediately understand that this PR adds reusable documentation snippets for these two topics.
Test Coverage For New Implementations ✅ Passed This PR contains exclusively documentation changes, specifically adding two new MDX partial files (_partial-mcp-node-tip.mdx and _partial-podman-alt.mdx) and integrating them into existing documentation pages. The PR does not introduce any new code components, functionality, features, or bug fixes—it only modifies documentation files. The test coverage check instructions are designed for code implementations, feature additions, and bug fixes that require unit and integration tests. Since no code changes or functional implementations are present in this PR, test files are not applicable or required.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 30, 2025
@github-actions

This comment has been minimized.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/docs/Deployment/deployment-docker.mdx (1)

6-9: Move the Podman tip admonition after the introductory paragraph for better readability.

The PartialPodmanAlt component is correctly defined and imported, but currently placed at line 8, before the introductory context. Since the tip references "all commands shown here," readers should understand the page's purpose first. Move the component to after line 10 (after "Running applications in Docker containers...") so the Podman alternative is presented after context is established.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e24c387 and 0f08008.

📒 Files selected for processing (6)
  • docs/docs/Agents/mcp-client.mdx (2 hunks)
  • docs/docs/Agents/mcp-component-astra.mdx (1 hunks)
  • docs/docs/Deployment/deployment-docker.mdx (1 hunks)
  • docs/docs/Deployment/develop-application.mdx (1 hunks)
  • docs/docs/_partial-mcp-node-tip.mdx (1 hunks)
  • docs/docs/_partial-podman-alt.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (.cursor/rules/docs_development.mdc)

docs/**/*.{md,mdx}: All Markdown/MDX pages must start with front matter including at least title and description; include sidebar_position for docs pages when applicable
Code blocks must specify a language and may include a title (```lang title="…")
Use sentence case for headings and keep paragraphs short and scannable
Write in second person, present tense, with a professional but approachable tone
Use inline code with backticks for code terms; use bold for UI elements and italics for emphasis; keep lists in parallel structure
Ensure internal links are functional and navigation works (update cross-references as needed)
Verify all code examples in docs and blog actually run as shown
Use correct terminology capitalization: Langflow, Component, Flow, API, JSON
Reference images with absolute paths under /img/... and provide descriptive alt text

Files:

  • docs/docs/_partial-podman-alt.mdx
  • docs/docs/Deployment/deployment-docker.mdx
  • docs/docs/_partial-mcp-node-tip.mdx
  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Deployment/develop-application.mdx
  • docs/docs/Agents/mcp-component-astra.mdx
docs/docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (.cursor/rules/docs_development.mdc)

Use Docusaurus admonitions (:::+tip|warning|danger) instead of custom callouts in docs pages

Files:

  • docs/docs/_partial-podman-alt.mdx
  • docs/docs/Deployment/deployment-docker.mdx
  • docs/docs/_partial-mcp-node-tip.mdx
  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Deployment/develop-application.mdx
  • docs/docs/Agents/mcp-component-astra.mdx
🧠 Learnings (9)
📓 Common learnings
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-09-30T00:09:51.631Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use Docusaurus admonitions (:::+tip|warning|danger) instead of custom callouts in docs pages
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-09-30T00:09:51.631Z
Learning: Applies to docs/docs/components/**/*.{md,mdx} : Component docs must follow the component page template with Overview, Configuration (Inputs/Outputs tables), Usage Example, and Common Issues sections
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-09-30T00:09:51.631Z
Learning: Applies to docs/sidebars.js : Keep sidebars.js updated to include new/changed docs sections and items using Docusaurus category structure
📚 Learning: 2025-06-23T12:46:52.420Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).

Applied to files:

  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Deployment/develop-application.mdx
  • docs/docs/Agents/mcp-component-astra.mdx
📚 Learning: 2025-06-23T12:46:42.048Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-23T12:46:42.048Z
Learning: Custom React Flow node types should be implemented as memoized components, using Handle components for connection points and supporting optional icons and labels.

Applied to files:

  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Deployment/develop-application.mdx
📚 Learning: 2025-06-16T11:14:04.200Z
Learnt from: dolfim-ibm
PR: langflow-ai/langflow#8394
File: src/frontend/src/icons/Docling/index.tsx:4-6
Timestamp: 2025-06-16T11:14:04.200Z
Learning: The Langflow codebase consistently uses `React.PropsWithChildren<{}>` as the prop type for all icon components using forwardRef, rather than `React.SVGProps<SVGSVGElement>`. This is an established pattern across hundreds of icon files in src/frontend/src/icons/.

Applied to files:

  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Deployment/develop-application.mdx
📚 Learning: 2025-07-23T21:19:22.567Z
Learnt from: deon-sanchez
PR: langflow-ai/langflow#9158
File: src/backend/base/langflow/api/v1/mcp_projects.py:404-404
Timestamp: 2025-07-23T21:19:22.567Z
Learning: In langflow MCP projects configuration, prefer using dynamically computed URLs (like the `sse_url` variable) over hardcoded localhost URLs to ensure compatibility across different deployment environments.

Applied to files:

  • docs/docs/Agents/mcp-client.mdx
  • docs/docs/Agents/mcp-component-astra.mdx
📚 Learning: 2025-09-30T00:09:51.631Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-09-30T00:09:51.631Z
Learning: Applies to docs/sidebars.js : Keep sidebars.js updated to include new/changed docs sections and items using Docusaurus category structure

Applied to files:

  • docs/docs/Deployment/develop-application.mdx
📚 Learning: 2025-07-18T18:27:12.609Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-07-18T18:27:12.609Z
Learning: Applies to src/frontend/src/components/**/@(FlowGraph|nodes)/**/*.{ts,tsx,js,jsx} : Use React Flow for flow graph visualization components.

Applied to files:

  • docs/docs/Deployment/develop-application.mdx
📚 Learning: 2025-09-30T00:09:51.631Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-09-30T00:09:51.631Z
Learning: Applies to docs/**/*.{md,mdx} : Use correct terminology capitalization: Langflow, Component, Flow, API, JSON

Applied to files:

  • docs/docs/Deployment/develop-application.mdx
📚 Learning: 2025-07-18T18:27:12.609Z
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-07-18T18:27:12.609Z
Learning: Applies to src/frontend/src/icons/**/*.{ts,tsx,js,jsx} : Use Lucide React for icons in the frontend.

Applied to files:

  • docs/docs/Deployment/develop-application.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test Docs Build / Test Docs Build
  • GitHub Check: build-and-deploy
🔇 Additional comments (5)
docs/docs/_partial-podman-alt.mdx (1)

1-3: MDX partial structure and content are correct.

The partial follows proper Docusaurus admonition formatting and is appropriately scoped for reuse across deployment documentation. The link to Podman documentation uses proper Markdown syntax.

docs/docs/Deployment/develop-application.mdx (1)

7-9: Partial import and rendering follow established patterns.

The PartialPodmanAlt component is correctly imported and rendered at the top of the page, maintaining consistency with the deployment-docker.mdx page. The placement and syntax are appropriate.

docs/docs/Agents/mcp-component-astra.mdx (1)

7-13: Partial placement within procedural steps is contextually appropriate.

The PartialMcpNodeTip is rendered after the Node.js installation step (step 1) and before the OpenAI setup (step 2), which logically aligns with the partial's content about Node.js prerequisites and Docker container setup. The import syntax is correct.

docs/docs/Agents/mcp-client.mdx (1)

8-39: Partial placement between procedure steps is clear and contextually sound.

The PartialMcpNodeTip is rendered after explaining the STDIO, JSON, and SSE options for adding an MCP server (line 39), providing setup prerequisites and guidance at a natural pause point in the procedure. The import syntax and component placement are correct.

docs/docs/_partial-mcp-node-tip.mdx (1)

1-7: Links are correctly formatted and will resolve as intended.

Both internal links in the partial follow the repository's established Docusaurus conventions and resolve correctly:

  • /develop-application#package-management links to the page with slug: /develop-application and the heading "### Package management" (which converts to anchor #package-management)
  • /mcp-component-astra links to the page with slug: /mcp-component-astra

Both target pages exist at their expected locations, and the link format matches patterns used throughout the documentation.

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@mendonk mendonk added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit c4e77ad Oct 30, 2025
20 checks passed
@mendonk mendonk deleted the docs-add-node-to-run-mcp-in-docker-commands branch October 30, 2025 21:39
korenLazar pushed a commit to kiran-kate/langflow that referenced this pull request Nov 13, 2025
* add-partial-for-mcp-note

* use-podman-option

* reword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants