-
Notifications
You must be signed in to change notification settings - Fork 8.2k
fix: changed embedding model to have api base and watsonx api endpoint #10524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+73
−17
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2231903
Changed embedding model to have api base and watsonx api endpoint
lucaseduoli 40e9d75
updated tests
lucaseduoli 32c8154
Fixed tests
lucaseduoli 5f86e16
Merge branch 'main' into fix/ollama_embedding_model
edwinjosechittilappilly eb43a70
Update component_index.json
edwinjosechittilappilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Provider logic looks solid; make
project_idrequired for IBM to match runtime check.Build raises if
project_idis missing, but the UI doesn’t mark it required when IBM watsonx.ai is selected.Apply inside the Python code string’s
update_build_configIBM branch:elif field_value == "IBM watsonx.ai": build_config["model"]["options"] = WATSONX_EMBEDDING_MODEL_NAMES build_config["model"]["value"] = WATSONX_EMBEDDING_MODEL_NAMES[0] build_config["api_key"]["display_name"] = "IBM watsonx.ai API Key" build_config["api_key"]["required"] = True build_config["api_key"]["show"] = True build_config["api_base"]["show"] = False build_config["base_url_ibm_watsonx"]["show"] = True build_config["project_id"]["show"] = True + build_config["project_id"]["required"] = TrueAlso, consider passing
request_timeout/max_retriesto Ollama if supported by the version in use. Low priority.🌐 Web query:
💡 Result:
Yes.
langchain_ibm==0.3.19 — WatsonxEmbeddings constructor accepts model_id, url, apikey (and optional project_id/space_id). [1][2]
langchain_openai==0.3.23 — OpenAIEmbeddings accepts a request_timeout / timeout parameter and a show_progress_bar boolean. [3][4]
Sources:
Mark
project_idrequired in UI for IBM watsonx.ai to match runtime validation.The
build_embeddings()method raisesValueErrorifproject_idis missing for IBM watsonx.ai, butupdate_build_config()only setsshow=Truewithout marking itrequired=True.Apply inside the Python code string's
update_build_configIBM branch:elif field_value == "IBM watsonx.ai": build_config["model"]["options"] = WATSONX_EMBEDDING_MODEL_NAMES build_config["model"]["value"] = WATSONX_EMBEDDING_MODEL_NAMES[0] build_config["api_key"]["display_name"] = "IBM watsonx.ai API Key" build_config["api_key"]["required"] = True build_config["api_key"]["show"] = True build_config["api_base"]["show"] = False build_config["base_url_ibm_watsonx"]["show"] = True build_config["project_id"]["show"] = True + build_config["project_id"]["required"] = TrueWatsonxEmbeddings constructor accepts
model_id,url,apikey, and optionallyproject_id, and OpenAIEmbeddings accepts bothtimeoutandshow_progress_barparameters—the code passes these correctly.📝 Committable suggestion
🤖 Prompt for AI Agents