Skip to content

fix(code-editor): prevent modal from closing when escape is pressed in search box #10585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TejasQ wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(code-editor): prevent modal from closing when escape is pressed in search box #10585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d482c8
Add check for search box
TejasQ Nov 13, 2025
13ed745
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/frontend/src/modals/codeAreaModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,19 @@ export default function CodeAreaModal({
<BaseModal
onEscapeKeyDown={(e) => {
e.preventDefault();

// Check if AceEditor search box input is in the viewport
const searchInput = document.querySelector(
"input.ace_search_field",
) as HTMLInputElement;
const isSearchBoxVisible =
searchInput && searchInput.offsetParent !== null; // Check if element is visible

// If search box is visible, don't close the modal - let AceEditor handle escape
if (isSearchBoxVisible) {
return;
}

if (code === value) {
setOpen(false);
} else {
Expand Down
Loading