fix: Ensure split text test is more robust

[erichare]

This pull request updates the unit test for the text splitting component to make it more robust and less dependent on the exact content length from URLs. The changes ensure the test remains valid regardless of variations in URL-loaded content and also add an explicit check for the expected output columns.

Test improvements for robustness and clarity:

• Increased the chunk_size and chunk_overlap in the test to accommodate varying URL content lengths, ensuring the test focuses on validating splitting functionality rather than specific chunk counts.
• Updated assertions to require at least as many output chunks as input rows (instead of more than two), and added a check to ensure the output DataFrame contains a "text" column.

Summary by CodeRabbit

• Tests
  • Refined text splitting validation for URL-loaded content with adjusted chunking parameters and updated assertion checks to ensure proper "text" field inclusion in results.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Test modifications relax expectations for URL-loaded text splitting by increasing chunking parameters (chunk_size from 10 to 1000, chunk_overlap from 0 to 200) and adjusting assertions to verify at least 2 rows and presence of a "text" column. Clarifying comments explain the test validates splitting behavior for URL content.

Changes

Cohort / File(s)	Summary
SplitText Component Test src/backend/tests/unit/components/processing/test_split_text_component.py	Updated URL loader test path with relaxed chunking parameters (chunk_size: 10→1000, chunk_overlap: 0→200), adjusted row count assertion (>2→≥2), added verification for "text" column presence, and included clarifying comments on test intent

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Parameter value changes (chunk_size, chunk_overlap) should be verified as intentional and correct
• Assertion logic change from strict inequality to inclusive comparison warrants verification

Possibly related PRs

• fix: Split text should only have dataframe output #8362: Modifies SplitText component tests with related changes to URL-loader path and DataFrame "text" column assertions

Suggested labels

lgtm

Suggested reviewers

• edwinjosechittilappilly
• rodrigosnader
• mfortman11

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)

Check name	Status	Explanation	Resolution
Test Quality And Coverage	❓ Inconclusive	The test file content is not accessible in the repository context, preventing evaluation of whether tests cover main functionality beyond smoke tests, follow pytest patterns correctly, and meaningfully validate splitting behavior.	Provide access to the full content of test_split_text_component.py to verify test coverage, pytest compliance, and proper validation of text-splitting functionality.
Test File Naming And Structure	❓ Inconclusive	Test file follows naming convention (test_*.py) and proper backend structure, but insufficient detail provided to verify test function descriptiveness, setup/teardown organization, edge case coverage, and negative scenario testing. Additionally, a style violation (whitespace on blank line) was noted in review comments.	Verify test function names are descriptive, confirm proper pytest setup/teardown implementation, ensure edge cases and negative scenarios are covered, and remove the whitespace violation from line 256 as indicated in the review.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: making the split text test more robust by relaxing exact expectations and improving assertions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Test Coverage For New Implementations	✅ Passed	This PR updates an existing test to improve robustness by making assertions less brittle, accounting for real-world variations, and validating output structure without adding untested functionality.
Excessive Mock Usage Warning	✅ Passed	The test file demonstrates appropriate and minimal use of mocks, testing real component objects and actual splitting behavior while mocking only external infrastructure. The PR improves test quality by making assertions more robust.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9eb5046 and 7595b3e.

📒 Files selected for processing (1)

• src/backend/tests/unit/components/processing/test_split_text_component.py (2 hunks)

🧰 Additional context used

🪛 GitHub Actions: Ruff Style Check

src/backend/tests/unit/components/processing/test_split_text_component.py

[error] 256-256: ruff check failed: W293 Blank line contains whitespace.

🪛 GitHub Check: Ruff Style Check (3.13)

src/backend/tests/unit/components/processing/test_split_text_component.py

[failure] 256-256: Ruff (W293)
src/backend/tests/unit/components/processing/test_split_text_component.py:256:1: W293 Blank line contains whitespace

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: Lint Backend / Run Mypy (3.13)
• GitHub Check: Test Docker Images / Test docker images
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 4
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 5
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 1
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 2
• GitHub Check: Run Backend Tests / LFX Tests - Python 3.10
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 3
• GitHub Check: Run Backend Tests / Integration Tests - Python 3.10
• GitHub Check: Test Starter Templates
• GitHub Check: Update Component Index

🔇 Additional comments (1)

src/backend/tests/unit/components/processing/test_split_text_component.py (1)

257-276: LGTM! Test changes align well with the PR objectives.

The modifications successfully make the test more robust:

• Increased chunk parameters (chunk_size: 10→1000, chunk_overlap: 0→200) accommodate varying URL content lengths
• Relaxed assertion (≥2 rows instead of a fixed threshold) focuses on validating core splitting functionality
• Explicit "text" column check adds defensive validation
• Clear comments document the rationale

The trade-off is reduced test specificity (shorter URL content might not exercise splitting extensively), but this is intentional and appropriate given the goal of reducing flakiness from variable URL content.

[github-actions]

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	14.68% (3983/27130)	7.57% (1560/20599)	8.94% (535/5982)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
1630	0 💤	0 ❌	0 🔥	19.819s ⏱️

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.62%. Comparing base (9eb5046) to head (44adb43).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (38.91%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10622   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files        1348     1348           
  Lines       61098    61098           
  Branches     9129     9129           
=======================================
  Hits        19322    19322           
  Misses      40863    40863           
  Partials      913      913           

Flag	Coverage Δ
backend	51.83% <ø> (ø)
frontend	13.59% <ø> (ø)
lfx	38.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.