Draft: feat: add network isolation controls for high-compliance deployments

[henricook]

Summary

Add environment variable controls for network isolation in high-compliance, air-gapped, or security-restricted deployments.

Changes

• feat: Add LANGFLOW_DISABLE_VERSION_CHECK to skip PyPI version checks
• feat: Add LANGFLOW_ALLOW_REMOTE_COMPONENT_INDEX to block remote component indices by default
• fix: Fix StoreService to properly honor store=false setting
• feat: Add configurable database pool sizes via environment variables (LANGFLOW_DB_POOL_SIZE, LANGFLOW_DB_MAX_OVERFLOW, LANGFLOW_DB_POOL_TIMEOUT)

Motivation

Organizations with strict network policies need controls to:

• Disable outbound calls to PyPI for version checking
• Block loading component indices from untrusted URLs
• Prevent store marketplace access in restricted environments
• Tune database connection pools for memory-constrained containers

Backward Compatibility

All changes are opt-in via environment variables. Default behavior is unchanged.

Summary by CodeRabbit

• New Features

  • Store interactions can now be disabled via configuration settings

• Security Improvements

  • Remote component index loading restricted by default for enhanced security

• Configuration

  • Version checking and database connection pool settings now configurable via environment variables

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

These changes add environment variable-based configuration controls and disable flags across multiple components. Store interactions, version checking, and remote component index loading are now conditionally disabled based on environment variables. Database pool settings are made configurable through environment variables with new defaults.

Changes

Cohort / File(s)	Summary
Store Service Disable Flag src/backend/base/langflow/services/store/service.py	Added _disabled flag to StoreService that prevents initialization and API key verification when store is disabled via settings
Version Check Disable src/backend/base/langflow/utils/version.py	Added import of os and guard in fetch_latest_version to skip PyPI version fetch when LANGFLOW_DISABLE_VERSION_CHECK environment variable is set to "true"
Remote Component Index Security src/lfx/src/lfx/interface/components.py	Added security check to block remote HTTP/HTTPS component index loading unless LANGFLOW_ALLOW_REMOTE_COMPONENT_INDEX is explicitly enabled; returns None and logs error if not allowed
Database Pool Configuration src/lfx/src/lfx/services/settings/base.py	Converted fixed database pool settings to environment-driven defaults: pool_size (20→5), max_overflow (30→10), and added pool_timeout (30); changes applied to both top-level Settings fields and nested db_connection_settings

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• All changes follow consistent patterns (environment variable guards and configuration defaults)
• Minimal logic density—mostly conditional checks and setting overrides
• Limited scope with straightforward semantic modifications
• Consider verifying that default environment variable values align with intended performance/security requirements

Suggested labels

size:M

Suggested reviewers

• mfortman11

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	Pull request introduces new functionality across four files without corresponding test coverage for critical features like StoreService disabling, version checks, remote component blocking, and database pool configuration.	Add comprehensive unit and integration tests for all modified modules validating happy paths, error conditions, boundary values, and environment variable parsing per project conventions.
Test Quality And Coverage	⚠️ Warning	Pull request introduces significant functionality across four files but includes no test files or coverage for new disabled state logic, environment variable parsing, and pool configuration changes.	Add comprehensive unit and integration tests covering StoreService disabled state, environment variable validation with bounds checking, and all code paths for new guards and early exit logic.
Test File Naming And Structure	❓ Inconclusive	Unable to access repository to verify test file patterns, naming conventions, and coverage for modified source files.	Examine PR on GitHub or local repository to verify test files match modified sources and cover new environment variables.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'add network isolation controls for high-compliance deployments' clearly and specifically summarizes the main change across all file modifications, which collectively introduce environment-variable controls to restrict network access and configure security-sensitive settings.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Excessive Mock Usage Warning	✅ Passed	No test files exist in this repository or PR, so there are no mocks to review for excessive usage.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c802fb and a1899e4.

📒 Files selected for processing (4)

• src/backend/base/langflow/services/store/service.py (2 hunks)
• src/backend/base/langflow/utils/version.py (2 hunks)
• src/lfx/src/lfx/interface/components.py (1 hunks)
• src/lfx/src/lfx/services/settings/base.py (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/backend/base/langflow/services/store/service.py (1)

src/backend/tests/unit/api/v2/test_mcp_servers_file.py (1)

• settings_service (96-97)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)

• GitHub Check: Lint Backend / Run Mypy (3.11)
• GitHub Check: Lint Backend / Run Mypy (3.10)
• GitHub Check: Lint Backend / Run Mypy (3.12)
• GitHub Check: Run Backend Tests / Integration Tests - Python 3.10
• GitHub Check: Run Frontend Tests / Determine Test Suites and Shard Distribution
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 5
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 3
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 2
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 4
• GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 1
• GitHub Check: Test Starter Templates
• GitHub Check: Run Backend Tests / LFX Tests - Python 3.10
• GitHub Check: Optimize new Python code in this PR
• GitHub Check: Run Ruff Check and Format
• GitHub Check: Update Component Index

🔇 Additional comments (3)

src/backend/base/langflow/utils/version.py (1)

78-80: LGTM! Clean implementation of version check disable flag.

The environment variable guard is correctly implemented with case-insensitive comparison and early return, consistent with the function's existing error handling pattern.

src/lfx/src/lfx/interface/components.py (1)

92-98: LGTM! Well-implemented security control.

The remote component index guard follows security best practices with a secure default (opt-in) and clear error messaging. The placement correctly prevents the httpx fetch before authorization.

src/backend/base/langflow/services/store/service.py (1)

117-119: Verify consistency with early return in __init__.

This defensive check is good, but it's only present in check_api_key. Consider whether other public methods should have similar guards, especially given the early return in __init__ (lines 85-89) that leaves attributes uninitialized.