fix: update jina embedding model name in OLLAMA_EMBEDDING_MODELS constant

[amiraiman]

This PR fix jina embedding models not showing in ollama_embedding component due to the filtering done via a naive startsWith check. The jina embedding models lives under a jina/ namespace, but the model name in the constant does not include that namespace causing the check to fail. The change also remove the hardcoded suffix -base-en in the constant since jina also provides embedding model in other language like german (-base-de) or spanish (-base-es).

Summary by CodeRabbit

• Chores
  • Updated Ollama embedding model configuration to align with the latest model naming standards for improved system compatibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated an embedding model entry in the OLLAMA_EMBEDDING_MODELS constant list, replacing "jina-embeddings-v2-base-en" with "jina/jina-embeddings-v2" in the Ollama constants module.

Changes

Cohort / File(s)	Summary
Embedding Models Configuration src/lfx/src/lfx/base/models/ollama_constants.py	Updated OLLAMA_EMBEDDING_MODELS list entry from "jina-embeddings-v2-base-en" to "jina/jina-embeddings-v2"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 3 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	PR modifies ollama_constants.py to update Jina model names but adds no corresponding test coverage for the bug fix.	Add tests verifying the updated model constant and the ollama_embedding component's filtering logic with the new namespace prefix.
Test Quality And Coverage	❓ Inconclusive	Unable to access repository to assess test quality and coverage for the OLLAMA_EMBEDDING_MODELS constant change.	Provide access to ollama_constants.py, component implementation, test files, and confirmation of test coverage for namespace prefix and language variant handling.
Test File Naming And Structure	❓ Inconclusive	PR modifies only a constants file with no test files changed; unclear if test coverage is required for constant-only updates.	Clarify project policy on whether constant definition updates require corresponding test files or modifications.
Excessive Mock Usage Warning	❓ Inconclusive	Assessment of excessive mock usage in test files cannot be completed due to inability to access the repository codebase.	Repository needs to be accessible for inspection to examine test files for mock usage patterns and verify appropriate mock usage for external dependencies.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating the Jina embedding model name in the OLLAMA_EMBEDDING_MODELS constant from 'jina-embeddings-v2-base-en' to 'jina/jina-embeddings-v2', which directly addresses the issue of model discoverability.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}