Skip to content

Conversation

@Uday-sidagana
Copy link
Contributor

@Uday-sidagana Uday-sidagana commented Nov 27, 2025

This PR has a fix for Freshdesk Component throwing error:

Error building Component Freshdesk:
Invalid request data provided
Following fields are missing: {'description'}

Backend change: langflow/src/lfx/src/lfx/base/composio/composio_base.py

— Added a fix for RESERVED_ATTRIBUTES to avoid conflicts.

Summary by CodeRabbit

  • Bug Fixes
    • Strengthened detection and management of naming conflicts between user-defined attributes and reserved system fields to improve stability.
    • Enhanced consistency in how conflicting names are handled and protected across all operations, reducing potential issues when working with complex configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the community Pull Request from an external contributor label Nov 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Introduced a RESERVED_ATTRIBUTES class attribute to centralize handling of attribute name conflicts across the ComposioBaseComponent. Replaced ad-hoc field-specific conflict checks with generic lookups in this set, affecting field renaming, schema validation, action execution, and field protection logic.

Changes

Cohort / File(s) Summary
Reserved Attributes Centralization
src/lfx/src/lfx/base/composio/composio_base.py
Added RESERVED_ATTRIBUTES set constant defining conflicting attribute names; refactored _populate_actions_data, _validate_schema_inputs, execute_action, and _hide_all_action_fields methods to use generic membership checks against this set instead of hard-coded attribute names; expanded field protection logic to include app_name-prefixed variants of reserved attributes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Primary concern: Logic changes span multiple methods (_populate_actions_data, _validate_schema_inputs, execute_action, _hide_all_action_fields) that handle field naming, descriptions, and protection; ensure the reserved attributes mapping is applied consistently across all entry points
  • Attention areas: Verify that field renaming and description generation logic correctly handles both original and prefixed attribute names; confirm that execute_action properly maps renamed fields back to original API names; validate that all protected field scenarios include both reserved and prefixed variants

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • edwinjosechittilappilly

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 inconclusive)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error PR fixes Freshdesk Component bug by adding RESERVED_ATTRIBUTES and modifying composio_base.py methods, but no test files are mentioned as being added or modified. Add test files validating the fix: verify Freshdesk Component builds without missing description error, RESERVED_ATTRIBUTES mechanism correctly prefixes fields, descriptions are preserved, and execute_action maps renamed fields back to original API names.
Test Quality And Coverage ❓ Inconclusive Repository access required to verify test coverage for critical functionality changes in composio_base.py including RESERVED_ATTRIBUTES and field handling logic. Provide direct code changes, new test files, testing infrastructure details, and existing test patterns for Freshdesk component and ComposioBaseComponent.
Test File Naming And Structure ❓ Inconclusive PR modifies only source code (composio_base.py) without adding or modifying any test files, making test naming/structure assessment impossible. Clarify whether test files were added/modified in this PR, or determine if test coverage should be required for the bug fix changes made.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: fixing a Freshdesk component description error by handling reserved attributes in Composio's base component.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Excessive Mock Usage Warning ✅ Passed The custom check for excessive mock usage is inapplicable to this PR, which modifies only backend logic in composio_base.py without adding or modifying test files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Something isn't working label Nov 27, 2025
@autofix-ci
Copy link
Contributor

autofix-ci bot commented Nov 27, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 27, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 27, 2025
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
we need to refactor it in Future to make the base better.

@edwinjosechittilappilly edwinjosechittilappilly added this pull request to the merge queue Dec 8, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 8, 2025
Merged via the queue into langflow-ai:main with commit 9ed8321 Dec 8, 2025
24 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the Nov27ReservedAttributesFix branch December 8, 2025 17:52
Wallgau pushed a commit that referenced this pull request Dec 16, 2025
fix: Freshdesk and RESERVED_ATTRIBUTES

Co-authored-by: Edwin Jose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working community Pull Request from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants