Skip to content

Conversation

@Adam-Aghili
Copy link
Collaborator

@Adam-Aghili Adam-Aghili commented Nov 28, 2025

macos-13 runners are depricated adding back in macOS-latest

refs:
https://github.com/actions/runner-images
https://github.com/actions/partner-runner-images

Summary by CodeRabbit

  • Chores
    • Enhanced cross-platform test infrastructure by adding dedicated macOS AMD64 runners with improved hardware resources for Python 3.10 and 3.12 testing, ensuring better test coverage and performance across different architectures.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

The PR modifies the cross-platform test workflow to add macOS AMD64 matrix entries using larger runners (macos-latest-large) for Python 3.10 and 3.12 in both stable and experimental test matrices, replacing placeholder entries while preserving existing ARM64 and Windows configurations.

Changes

Cohort / File(s) Summary
GitHub Actions workflow configuration
.github/workflows/cross-platform-test.yml
Adds macOS AMD64 matrix entries using larger runners (macos-latest-large) for Python 3.10 and 3.12 in stable and experimental test matrices; replaces placeholder entries and removes prior comments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • ogabrielluiz

Pre-merge checks and finishing touches

✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add back in macOS amd64 runners' accurately describes the main change: reintroducing macOS AMD64 runners to the workflow after deprecation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Coverage For New Implementations ✅ Passed This PR modifies only GitHub Actions workflow configuration to update macOS runners, which is an infrastructure change that does not introduce new application code, features, or functional bug fixes requiring test coverage.
Test Quality And Coverage ✅ Passed This PR only modifies GitHub Actions workflow configuration to update CI/CD runner specifications without introducing new code functionality or testable implementations.
Test File Naming And Structure ✅ Passed The PR modifies only GitHub Actions workflow configuration (.github/workflows/cross-platform-test.yml), not actual test files or test implementations, making the custom check for test file naming and structure inapplicable.
Excessive Mock Usage Warning ✅ Passed The custom check for excessive mock usage is inapplicable to this PR as it only modifies GitHub Actions workflow configuration, not test files.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aka-macos-15

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 271c7ff and 2b7222a.

📒 Files selected for processing (1)
  • .github/workflows/cross-platform-test.yml (2 hunks)
🔇 Additional comments (2)
.github/workflows/cross-platform-test.yml (2)

92-100: Correctly implements macOS AMD64 runners using appropriate larger runner label.

The macos-latest-large runner is the correct label for 12-core macOS larger runners, providing AMD64 support that was previously unavailable with deprecated macos-13. The placement before ARM64 entries is logical, and the architecture/Python version mappings align with the stable test matrix pattern.


399-406: Experimental matrix entries mirror stable matrix approach with Python 3.13.

The experimental job correctly adds both macOS AMD64 and ARM64 entries for Python 3.13, maintaining consistency with the stable matrix structure. Since the experimental job uses continue-on-error: true, test failures on Python 3.13 won't block CI, which is appropriate for an experimental version.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants