-
Notifications
You must be signed in to change notification settings - Fork 8.2k
feat:slide chat header for new playground progressive parallel implementation #10795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace modal-based playground with a sliding container panel that slides in from the right side of the screen. The new implementation includes: - Reusable SlidingContainer component with resizable and fullscreen support - PlaygroundButtonSliding component that toggles the sliding container - Zustand store for managing sliding container state (open/closed, width, fullscreen) - FlowPageSlidingContainerContent component for playground panel content - Integration with existing FlowPage layout and keyboard shortcuts Changes are commented out for review and will be reverted when approved before merging to avoid affecting the current implementation.
Add comprehensive test coverage for: - SlidingContainerStore: state management, width constraints, fullscreen toggle - SlidingContainer: rendering, width behavior, resizing, transitions - PlaygroundButtonSliding: button states, icon rendering, click handlers All tests follow existing patterns using Jest and React Testing Library.
Remove NOTE comments that were added for review purposes. Clean up commented-out old implementation code.
Revert to original PlaygroundButton and IOModal implementation. Remove sliding container code and restore original behavior.
- Add sliding container component for playground panel - Integrate chat header with session rename, delete, and message logs - Add session sidebar in fullscreen mode - Implement session fetching and management - Add rename functionality with optimistic updates - Fix sessionStorage JSON parsing bug in use-rename-session and use-put-update-messages - Comment out IOModal to test sliding container (will be reverted before merge) - Add basic tests for sliding container components
- Merge session-more-menu-items into session-more-menu (single file) - Remove redundant chat-header-more-menu wrapper - Use SessionMoreMenu directly in chat-header and session-selector - Fix spacing in non-fullscreen mode: flex-2 for left side, flex-1 for right side - Remove flex-1 from title to prevent spacing issues with short names - Group more menu and actions together to keep them close to expand button - Fix TypeScript any types in test file - Clean up unused components and improve code organization
- Change slide container from absolute to flex layout - Flow now resizes dynamically based on slide container width (0px to 326px) - Add 0.5rem padding to flow container - Add 5px border-radius to bg-canvas and react-flow-id divs - Comment out original absolute positioning layout (will be reverted before merge) - Keep fullscreen mode with fixed positioning
- Hide 'Playground' text when slide container is open (width > 0px) - Show 'Playground' text when slide container is closed (0px) - Update Share button to have white background and black text
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…er-radius, codeAreaModal test)
…dComponent - Move sliding container components to core location - Create index files for cleaner imports - Update all import paths
No description provided.