-
Notifications
You must be signed in to change notification settings - Fork 8.2k
feat:Enable combobox for IBM WatsonX URL input fields #10818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
bfd6d06
600230c
0f9f91c
34b53ad
5dbfb94
184496b
d35fba7
0437972
442baa3
494aa58
6f459f2
d526c75
75136f6
ab9b8d5
ec50f68
7ddd96c
cd3b273
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of these two lines that set model_name options and value for IBM watsonx.ai appears unrelated to the PR's stated purpose of adding combobox functionality. This change means that when switching to IBM watsonx.ai provider, the model_name dropdown won't be populated with default models until the base_url_ibm_watsonx field is changed (which triggers the model fetch at line 336-338). This differs from other providers (OpenAI, Anthropic, Google) which immediately populate model options on provider selection. Was this intentional?