Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/lfx/src/lfx/_assets/component_index.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class EmbeddingModelComponent(LCEmbeddingsModel):
value=IBM_WATSONX_URLS[0],
show=False,
real_time_refresh=True,
combobox=True,
),
DropdownInput(
name="model",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def fetch_ibm_models(base_url: str) -> list[str]:
value=IBM_WATSONX_URLS[0],
show=False,
real_time_refresh=True,
combobox=True,
),
StrInput(
name="project_id",
Expand Down Expand Up @@ -269,11 +270,10 @@ async def update_build_config(
build_config["project_id"]["show"] = False
build_config["ollama_base_url"]["show"] = False
elif field_value == "IBM watsonx.ai":
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of these two lines that set model_name options and value for IBM watsonx.ai appears unrelated to the PR's stated purpose of adding combobox functionality. This change means that when switching to IBM watsonx.ai provider, the model_name dropdown won't be populated with default models until the base_url_ibm_watsonx field is changed (which triggers the model fetch at line 336-338). This differs from other providers (OpenAI, Anthropic, Google) which immediately populate model options on provider selection. Was this intentional?

Suggested change
elif field_value == "IBM watsonx.ai":
elif field_value == "IBM watsonx.ai":
build_config["model_name"]["options"] = IBM_WATSONX_DEFAULT_MODELS
build_config["model_name"]["value"] = IBM_WATSONX_DEFAULT_MODELS[0]

Copilot uses AI. Check for mistakes.
build_config["model_name"]["options"] = IBM_WATSONX_DEFAULT_MODELS
build_config["model_name"]["value"] = IBM_WATSONX_DEFAULT_MODELS[0]
build_config["api_key"]["display_name"] = "IBM API Key"
build_config["api_key"]["show"] = True
build_config["base_url_ibm_watsonx"]["show"] = True
build_config["base_url_ibm_watsonx"]["combobox"] = True
build_config["project_id"]["show"] = True
build_config["ollama_base_url"]["show"] = False
elif field_value == "Ollama":
Expand Down
Loading