fix: Restore logs modal functionality with transaction logging and proper display #10820
Conversation
Cristhianzl
requested review from
edwinjosechittilappilly,
erichare and
ogabrielluiz
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis PR introduces transaction logging for flow execution. The backend adds a new Changes
Sequence DiagramsequenceDiagram
participant Vertex as Vertex.build()
participant Logger as log_transaction()
participant Settings as Settings Service
participant DBService as LangFlow DB Service
participant CRUD as Transaction CRUD
participant DB as Database
Vertex->>Vertex: Execute vertex logic
rect rgb(200, 220, 240)
Note over Vertex,CRUD: Success Path
Vertex->>Logger: log_transaction(status="success")
Logger->>Settings: Check transactions_storage_enabled
Settings-->>Logger: Enabled
Logger->>DBService: Get DB service instance
DBService-->>Logger: Service ready
Logger->>CRUD: log_transaction(TransactionBase)
CRUD->>DB: INSERT transaction record
DB-->>CRUD: Record persisted
CRUD-->>Logger: Complete
end
rect rgb(240, 200, 200)
Note over Vertex,CRUD: Error Path
Vertex->>Vertex: Exception in _build_results
Vertex->>Logger: log_transaction(status="error")
Logger->>Settings: Check transactions_storage_enabled
Settings-->>Logger: Enabled
Logger->>DBService: Get DB service instance
DBService-->>Logger: Service ready
Logger->>CRUD: log_transaction(TransactionBase with error)
CRUD->>DB: INSERT transaction record
DB-->>CRUD: Record persisted
CRUD-->>Logger: Complete
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35–50 minutes Key areas requiring attention during review:
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touchesImportant Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 3 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
bug
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10820 +/- ##
==========================================
+ Coverage 33.09% 33.14% +0.05%
==========================================
Files 1389 1390 +1
Lines 65682 65734 +52
Branches 9720 9728 +8
==========================================
+ Hits 21737 21789 +52
- Misses 42830 42833 +3
+ Partials 1115 1112 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-actions
bot
added
bug
… into cz/add-logs-feature
github-actions
bot
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/lfx/src/lfx/graph/utils.py (1)
129-133: PotentialAttributeErrorifsourceisNone.Line 130 accesses
source.graph.flow_idwithout checking ifsourceisNone. However, line 144 suggestssourcecan beNone(if source else None). IfsourceisNoneandflow_idis falsy, this will raise anAttributeError.if not flow_id: - if source.graph.flow_id: + if source and source.graph.flow_id: flow_id = source.graph.flow_id else: returnsrc/lfx/src/lfx/graph/vertex/base.py (1)
530-556: Remove the blockingawaitand add proper cancellation error handling for background task logging.The
await taskon line 550 blocks the calling coroutine during I/O-bound database operations, unnecessarily stalling the vertex build process. Sincelog_transactionperforms async database operations, this synchronous wait extends the block to all callers of_log_transaction_async(lines 572, 578, 663, 784).Background logging tasks should run concurrently with proper cleanup. Remove the
await taskand instead rely on the done callback to manage completed tasks. Additionally, implement try/except handling forasyncio.CancelledErroras required by backend development guidelines, wrapping the task creation and management logic.
🧹 Nitpick comments (6)
src/lfx/src/lfx/graph/utils.py (1)
167-168: Silent exception swallowing may hide issues during debugging.The broad
except Exceptionclause logs errors only at thedebuglevel, which means transaction logging failures will be invisible unless debug logging is enabled. While this is likely intentional to prevent logging failures from affecting flow execution, consider logging atwarninglevel for unexpected errors to aid in debugging production issues.except Exception as exc: # noqa: BLE001 - logger.debug(f"Error logging transaction: {exc!s}") + logger.warning(f"Error logging transaction: {exc!s}")Alternatively, keep
debuglevel but ensure documentation notes this behavior.src/backend/tests/unit/api/v1/test_transactions.py (1)
88-111: Simplify field exclusion assertion for better clarity.Line 109 uses a complex assertion pattern to verify that
errorandflow_idare excluded from TransactionLogsResponse. Consider using a more direct check.Apply this diff for clearer assertions:
response = TransactionLogsResponse.model_validate(table, from_attributes=True) assert response.id == table.id assert response.vertex_id == table.vertex_id assert response.target_id == table.target_id assert response.status == table.status # TransactionLogsResponse should not have error and flow_id fields - assert not hasattr(response, "error") or "error" not in response.model_fields - assert not hasattr(response, "flow_id") or "flow_id" not in response.model_fields + assert "error" not in response.model_fields + assert "flow_id" not in response.model_fieldssrc/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsx (1)
1-108: Make Inputs/Outputs columns read‑only and slightly harden status renderingThe overall column config and
formatObjectValuehelper look good and solve the[object Object]issue. Two small tweaks would better match a read‑only logs view and handle edge cases:
- Inputs/Outputs should likely be non‑editable
These are historical log entries; making them editable can confuse users and may interact oddly with AG Grid’s edit flows:
{ headerName: "Inputs", field: "inputs", flex: 1.2, minWidth: 150, filter: false, sortable: false, - editable: true, + editable: false, cellClass: baseCellClass, valueGetter: (params) => formatObjectValue(params.data?.inputs), }, { headerName: "Outputs", field: "outputs", flex: 1.2, minWidth: 150, filter: false, sortable: false, - editable: true, + editable: false, cellClass: baseCellClass, valueGetter: (params) => formatObjectValue(params.data?.outputs), },
- Guard against missing status values
If
statusis everundefinedornull, you can avoid rendering"undefined"in the badge:- cellRenderer: (params: { value: string }) => { - const status = params.value; + cellRenderer: (params: { value: string | undefined | null }) => { + const status = params.value ?? "";This keeps the UI clean even for unexpected data.
src/frontend/src/modals/flowLogsModal/index.tsx (2)
36-47: Avoid mutating query data when normalizing timestampsIn the
useEffectyou currently:if (data) { const { rows } = data; if (data?.rows?.length > 0) { data.rows.map((row: any) => { row.timestamp = convertUTCToLocalTimezone(row.timestamp); }); } setRows(rows); }This mutates
data.rowsin place. IfuseGetTransactionsQuerycaches its responses (as React Query/RTK Query style hooks do), in‑place mutation can have surprising effects elsewhere.You can keep the behavior but avoid mutation by mapping to a new array:
if (data?.rows) { const normalizedRows = data.rows.map((row: any) => ({ ...row, timestamp: convertUTCToLocalTimezone(row.timestamp), })); setRows(normalizedRows); } else { setRows([]); }This keeps query results immutable and makes the transformation intent clearer.
20-25: Consider memoizing static column definitions
createFlowLogsColumns()returns a static set of column definitions, but it’s called on every render:const columns = createFlowLogsColumns();With AG Grid, changing the
columnDefsarray identity can trigger additional work. It’s minor here, but you can stabilize it withuseMemo:const columns = useMemo(() => createFlowLogsColumns(), []);(You’ll need to import
useMemo.) This keeps the grid configuration stable while still being simple.src/frontend/tests/extended/features/flow-logs-modal.spec.ts (1)
120-207: Scope success/error badge assertions to the logs dialogIn the success and error tests you currently assert on
"success"/"error"across the whole page:await expect(page.locator("text=success").first()).toBeVisible(); ... await expect(page.locator("text=error").first()).toBeVisible();This can match unrelated text (e.g., toasts or other components) and still pass even if the logs dialog doesn’t render the badge correctly.
Since this is specifically about the Flow Logs Modal, consider scoping to the dialog similar to the core logs test:
- // Verify success status badge is displayed - await expect(page.locator("text=success").first()).toBeVisible(); + // Verify success status badge is displayed inside the logs dialog + const dialog = page.getByLabel("Dialog"); + await expect(dialog.locator("text=success").first()).toBeVisible(); @@ - // Verify error status badge is displayed - await expect(page.locator("text=error").first()).toBeVisible(); + // Verify error status badge is displayed inside the logs dialog + const dialog = page.getByLabel("Dialog"); + await expect(dialog.locator("text=error").first()).toBeVisible();This keeps the assertions tightly coupled to the modal under test and reduces flakiness.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
src/backend/base/langflow/api/v1/monitor.py(2 hunks)src/backend/base/langflow/services/database/models/transactions/crud.py(2 hunks)src/backend/base/langflow/services/database/models/transactions/model.py(1 hunks)src/backend/tests/unit/api/v1/test_transactions.py(1 hunks)src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsx(1 hunks)src/frontend/src/modals/flowLogsModal/index.tsx(3 hunks)src/frontend/tests/core/features/logs.spec.ts(1 hunks)src/frontend/tests/extended/features/flow-logs-modal.spec.ts(1 hunks)src/lfx/src/lfx/graph/utils.py(2 hunks)src/lfx/src/lfx/graph/vertex/base.py(2 hunks)
🧰 Additional context used
📓 Path-based instructions (11)
src/backend/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/backend_development.mdc)
src/backend/**/*.py: Use FastAPI async patterns withawaitfor async operations in component execution methods
Useasyncio.create_task()for background tasks and implement proper cleanup with try/except forasyncio.CancelledError
Usequeue.put_nowait()for non-blocking queue operations andasyncio.wait_for()with timeouts for controlled get operations
Files:
src/backend/base/langflow/services/database/models/transactions/crud.pysrc/backend/base/langflow/services/database/models/transactions/model.pysrc/backend/tests/unit/api/v1/test_transactions.pysrc/backend/base/langflow/api/v1/monitor.py
src/backend/base/langflow/services/database/models/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/backend_development.mdc)
Database models should be organized by domain (api_key/, flow/, folder/, user/, etc.) under
src/backend/base/langflow/services/database/models/
Files:
src/backend/base/langflow/services/database/models/transactions/crud.pysrc/backend/base/langflow/services/database/models/transactions/model.py
src/frontend/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
src/frontend/src/**/*.{ts,tsx}: Use React 18 with TypeScript for frontend development
Use Zustand for state management
Files:
src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsxsrc/frontend/src/modals/flowLogsModal/index.tsx
src/frontend/src/**/*.{tsx,jsx,css,scss}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
Use Tailwind CSS for styling
Files:
src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsxsrc/frontend/src/modals/flowLogsModal/index.tsx
src/frontend/src/**/*.{tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
src/frontend/src/**/*.{tsx,jsx}: Implement dark mode support using the useDarkMode hook and dark store
Use Lucide React for icon components in the application
Files:
src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsxsrc/frontend/src/modals/flowLogsModal/index.tsx
src/frontend/**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)
src/frontend/**/*.{test,spec}.{ts,tsx,js,jsx}: Use@pytest.mark.asynciodecorator for async frontend tests; structure tests to verify component behavior, state updates, and proper cleanup
Frontend tests should validate component rendering, user interactions, state management, and async operations using appropriate testing libraries (React Testing Library, Vitest, Jest, etc.)
Document each frontend test with a clear docstring/comment explaining its purpose, the scenario being tested, and expected outcomes
Files:
src/frontend/tests/core/features/logs.spec.tssrc/frontend/tests/extended/features/flow-logs-modal.spec.ts
**/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py}
📄 CodeRabbit inference engine (Custom checks)
**/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py}: Review test files for excessive use of mocks that may indicate poor test design - check if tests have too many mock objects that obscure what's actually being tested
Warn when mocks are used instead of testing real behavior and interactions
Suggest using real objects or test doubles when mocks become excessive
Ensure mocks are used appropriately for external dependencies, not core logic
Test files should have descriptive test function names that explain what is being tested
Tests should be organized logically with proper setup and teardown
Consider including edge cases and error conditions for comprehensive coverage
Verify tests cover both positive and negative scenarios where appropriate
Tests should cover the main functionality being implemented
Check that tests are not just smoke tests but actually validate behavior
Ensure tests follow the project's testing patterns (pytest for backend, Playwright for frontend)
For API endpoints, verify both success and error response testing
Files:
src/frontend/tests/core/features/logs.spec.tssrc/frontend/tests/extended/features/flow-logs-modal.spec.ts
src/backend/tests/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)
src/backend/tests/**/*.py: Place backend unit tests insrc/backend/tests/directory, component tests insrc/backend/tests/unit/components/organized by component subdirectory, and integration tests accessible viamake integration_tests
Use same filename as component with appropriate test prefix/suffix (e.g.,my_component.py→test_my_component.py)
Use theclientfixture (FastAPI Test Client) defined insrc/backend/tests/conftest.pyfor API tests; it provides an asynchttpx.AsyncClientwith automatic in-memory SQLite database and mocked environment variables. Skip client creation by marking test with@pytest.mark.noclient
Inherit from the correctComponentTestBasefamily class located insrc/backend/tests/base.pybased on API access needs:ComponentTestBase(no API),ComponentTestBaseWithClient(needs API), orComponentTestBaseWithoutClient(pure logic). Provide three required fixtures:component_class,default_kwargs, andfile_names_mapping
Create comprehensive unit tests for all new backend components. If unit tests are incomplete, create a corresponding Markdown file documenting manual testing steps and expected outcomes
Test both sync and async code paths, mock external dependencies appropriately, test error handling and edge cases, validate input/output behavior, and test component initialization and configuration
Use@pytest.mark.asynciodecorator for async component tests and ensure async methods are properly awaited
Test background tasks usingasyncio.create_task()and verify completion withasyncio.wait_for()with appropriate timeout constraints
Test queue operations using non-blockingqueue.put_nowait()andasyncio.wait_for(queue.get(), timeout=...)to verify queue processing without blocking
Use@pytest.mark.no_blockbustermarker to skip the blockbuster plugin in specific tests
For database tests that may fail in batch runs, run them sequentially usinguv run pytest src/backend/tests/unit/test_database.pyr...
Files:
src/backend/tests/unit/api/v1/test_transactions.py
**/{test_*.py,*.test.ts,*.test.tsx}
📄 CodeRabbit inference engine (Custom checks)
Check that test files follow the project's naming conventions (test_*.py for backend, *.test.ts for frontend)
Files:
src/backend/tests/unit/api/v1/test_transactions.py
**/test_*.py
📄 CodeRabbit inference engine (Custom checks)
**/test_*.py: Backend tests should follow pytest structure with proper test_*.py naming
For async functions, ensure proper async testing patterns are used with pytest for backend
Files:
src/backend/tests/unit/api/v1/test_transactions.py
src/backend/base/langflow/api/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/backend_development.mdc)
Backend API endpoints should be organized by version (v1/, v2/) under
src/backend/base/langflow/api/with specific modules for features (chat.py, flows.py, users.py, etc.)
Files:
src/backend/base/langflow/api/v1/monitor.py
🧠 Learnings (22)
📚 Learning: 2025-11-24T19:46:45.790Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/src/components/**/*.{tsx,jsx} : Use React Flow for flow graph visualization with Node, Edge, Controls, and Background components
Applied to files:
src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsxsrc/frontend/src/modals/flowLogsModal/index.tsx
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/frontend/**/*.{test,spec}.{ts,tsx,js,jsx} : Document each frontend test with a clear docstring/comment explaining its purpose, the scenario being tested, and expected outcomes
Applied to files:
src/frontend/tests/core/features/logs.spec.tssrc/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:40.400Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-11-24T19:47:40.400Z
Learning: Applies to **/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py} : Ensure mocks are used appropriately for external dependencies, not core logic
Applied to files:
src/frontend/tests/core/features/logs.spec.tssrc/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-06-23T12:46:52.420Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: Export custom icon components in React using React.forwardRef to ensure proper ref forwarding and compatibility with parent components.
Applied to files:
src/frontend/src/modals/flowLogsModal/index.tsx
📚 Learning: 2025-11-24T19:46:45.790Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/src/**/*.{tsx,jsx} : Use Lucide React for icon components in the application
Applied to files:
src/frontend/src/modals/flowLogsModal/index.tsx
📚 Learning: 2025-06-16T11:14:04.200Z
Learnt from: dolfim-ibm
Repo: langflow-ai/langflow PR: 8394
File: src/frontend/src/icons/Docling/index.tsx:4-6
Timestamp: 2025-06-16T11:14:04.200Z
Learning: The Langflow codebase consistently uses `React.PropsWithChildren<{}>` as the prop type for all icon components using forwardRef, rather than `React.SVGProps<SVGSVGElement>`. This is an established pattern across hundreds of icon files in src/frontend/src/icons/.
Applied to files:
src/frontend/src/modals/flowLogsModal/index.tsx
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/frontend/**/*.{test,spec}.{ts,tsx,js,jsx} : Frontend tests should validate component rendering, user interactions, state management, and async operations using appropriate testing libraries (React Testing Library, Vitest, Jest, etc.)
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:40.400Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-11-24T19:47:40.400Z
Learning: Applies to **/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py} : Consider including edge cases and error conditions for comprehensive coverage
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:40.400Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-11-24T19:47:40.400Z
Learning: Applies to **/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py} : Tests should cover the main functionality being implemented
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/frontend/**/*.{test,spec}.{ts,tsx,js,jsx} : Use `pytest.mark.asyncio` decorator for async frontend tests; structure tests to verify component behavior, state updates, and proper cleanup
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:40.400Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-11-24T19:47:40.400Z
Learning: Applies to **/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py} : Ensure tests follow the project's testing patterns (pytest for backend, Playwright for frontend)
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:47:40.400Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-11-24T19:47:40.400Z
Learning: Applies to **/*.{test.ts,test.tsx,spec.ts,spec.tsx,test_*.py} : Verify tests cover both positive and negative scenarios where appropriate
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-11-24T19:46:45.790Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/**/*.test.{ts,tsx} : Write component tests using React Testing Library with render(), screen, and fireEvent utilities
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-06-23T12:46:42.048Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-06-23T12:46:42.048Z
Learning: Frontend tests should be written using testing-library/react, with both component and integration tests verifying rendering, user interaction, and data loading.
Applied to files:
src/frontend/tests/extended/features/flow-logs-modal.spec.ts
📚 Learning: 2025-08-07T20:23:23.569Z
Learnt from: edwinjosechittilappilly
Repo: langflow-ai/langflow PR: 0
File: :0-0
Timestamp: 2025-08-07T20:23:23.569Z
Learning: The Langflow codebase has an excellent structlog implementation that follows best practices, with proper global configuration, environment-based output formatting, and widespread adoption across components. The main cleanup needed is updating starter project templates and documentation examples that still contain legacy `from loguru import logger` imports.
Applied to files:
src/lfx/src/lfx/graph/utils.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Test both sync and async code paths, mock external dependencies appropriately, test error handling and edge cases, validate input/output behavior, and test component initialization and configuration
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Create comprehensive unit tests for all new backend components. If unit tests are incomplete, create a corresponding Markdown file documenting manual testing steps and expected outcomes
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Test Langflow REST API endpoints using the `client` fixture with appropriate HTTP methods (GET, POST, etc.), headers (logged_in_headers), and payload validation
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Use predefined JSON flows and utility functions from `tests.unit.build_utils` (create_flow, build_flow, get_build_events, consume_and_assert_stream) for flow execution testing
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Use `monkeypatch` fixture to mock internal functions for testing error handling scenarios; validate error status codes and error message content in responses
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Test Langflow's `Message` objects using `langflow.schema.message.Message` and validate text, sender, sender_name, session_id, files, and properties attributes
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.pysrc/backend/base/langflow/api/v1/monitor.py
📚 Learning: 2025-11-24T19:47:28.997Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-11-24T19:47:28.997Z
Learning: Applies to src/backend/tests/**/*.py : Test component versioning and backward compatibility using `file_names_mapping` fixture with `VersionComponentMapping` objects mapping component files across Langflow versions
Applied to files:
src/backend/tests/unit/api/v1/test_transactions.py
🧬 Code graph analysis (7)
src/backend/base/langflow/services/database/models/transactions/crud.py (1)
src/backend/base/langflow/services/database/models/transactions/model.py (2)
TransactionLogsResponse(86-107)TransactionTable(76-78)
src/frontend/src/modals/flowLogsModal/index.tsx (1)
src/frontend/src/modals/flowLogsModal/config/flowLogsColumns.tsx (1)
createFlowLogsColumns(21-108)
src/frontend/tests/extended/features/flow-logs-modal.spec.ts (2)
src/frontend/tests/utils/await-bootstrap-test.ts (1)
awaitBootstrapTest(4-67)src/frontend/tests/utils/add-custom-component.ts (1)
addCustomComponent(3-12)
src/backend/base/langflow/services/database/models/transactions/model.py (1)
src/backend/base/langflow/serialization/serialization.py (3)
serialize(253-305)get_max_text_length(31-33)get_max_items_length(37-39)
src/lfx/src/lfx/graph/utils.py (3)
src/lfx/src/lfx/graph/vertex/base.py (1)
Vertex(46-837)src/backend/base/langflow/services/database/models/transactions/crud.py (1)
log_transaction(30-75)src/backend/base/langflow/services/database/models/transactions/model.py (1)
TransactionBase(10-73)
src/backend/tests/unit/api/v1/test_transactions.py (2)
src/backend/base/langflow/services/database/models/transactions/crud.py (2)
transform_transaction_table(78-83)transform_transaction_table_for_logs(86-92)src/backend/base/langflow/services/database/models/transactions/model.py (4)
TransactionBase(10-73)TransactionLogsResponse(86-107)TransactionReadResponse(81-83)TransactionTable(76-78)
src/backend/base/langflow/api/v1/monitor.py (2)
src/backend/base/langflow/services/database/models/transactions/crud.py (1)
transform_transaction_table_for_logs(86-92)src/backend/base/langflow/services/database/models/transactions/model.py (2)
TransactionLogsResponse(86-107)TransactionTable(76-78)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (65)
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 39/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 48/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 42/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 49/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 47/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 46/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 44/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 40/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 37/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 50/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 41/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 38/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 43/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 45/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 31/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 36/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 33/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 34/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 32/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 35/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 30/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 27/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 28/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 29/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 25/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 19/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 12/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 23/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 24/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 22/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 26/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 13/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 21/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 20/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 18/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 17/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 15/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 8/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 5/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 9/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 16/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 14/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 11/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 4/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 6/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 10/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 7/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 1/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 2/50
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 3/50
- GitHub Check: Lint Backend / Run Mypy (3.13)
- GitHub Check: Lint Backend / Run Mypy (3.10)
- GitHub Check: Lint Backend / Run Mypy (3.11)
- GitHub Check: Lint Backend / Run Mypy (3.12)
- GitHub Check: Test Docker Images / Test docker images
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 4
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 5
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 2
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 1
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 3
- GitHub Check: Run Backend Tests / LFX Tests - Python 3.10
- GitHub Check: Run Backend Tests / Integration Tests - Python 3.10
- GitHub Check: Test Starter Templates
- GitHub Check: Optimize new Python code in this PR
- GitHub Check: Update Starter Projects
🔇 Additional comments (7)
src/lfx/src/lfx/graph/vertex/base.py (2)
660-665: LGTM! Transaction error logging properly captures build failures.The error logging correctly:
- Checks for flow_id availability before logging
- Passes the exception message as the error parameter
- Uses status="error" appropriately
781-784: LGTM! Transaction success logging properly captures successful builds.The success logging correctly records the completion of the build process with appropriate parameters.
src/backend/base/langflow/services/database/models/transactions/model.py (1)
86-107: LGTM! TransactionLogsResponse model is well-designed for the logs view.The model correctly:
- Excludes internal fields (error, flow_id) as documented
- Applies serialization limits consistently with TransactionBase
- Configures
from_attributes=Truefor proper ORM conversionsrc/backend/tests/unit/api/v1/test_transactions.py (1)
1-228: LGTM! Comprehensive test coverage for transactions functionality.The test file provides excellent coverage:
- Model creation and validation (including edge cases like code filtering)
- Transformer functions for both single items and lists
- API endpoint authentication, pagination, and validation
- Response structure verification
src/backend/base/langflow/api/v1/monitor.py (2)
14-15: LGTM! Imports correctly updated for logs functionality.The imports properly reference the new transformer function and response model for the logs view.
180-198: LGTM! Endpoint correctly refactored to return logs-specific response.The changes properly:
- Update the return type to
Page[TransactionLogsResponse]- Order transactions by timestamp descending for recent-first display
- Apply the new
transform_transaction_table_for_logstransformersrc/frontend/tests/extended/features/flow-logs-modal.spec.ts (1)
5-212: Nice coverage of Flow Logs Modal behaviorsThese tests do a good job covering the main flows:
- Opening the modal and verifying the description.
- Empty state (
"No Data Available").- Closing with Escape.
- Success and error executions reflected in the logs.
They align well with the new logs modal behavior and backend transaction logging and should catch regressions around modal wiring and status badges.
github-actions
bot
added
bug
github-actions
bot
added
bug
Summary
TransactionLogsResponsemodel to return only necessary fields for logs view[object Object]by adding proper JSON formattingChanges
Backend
TransactionLogsResponsemodel excludingerrorandflow_idfieldstransform_transaction_table_for_logsfunctionlog_transactionto save to database using langflow's servicesFrontend
Tests