-
Notifications
You must be signed in to change notification settings - Fork 8.2k
fix(ci): Allow prerelease packages and fix runtime type imports #10945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7812ef6
3ad9b02
cca4209
8830b3a
712cfe7
8b0fcd4
8dad2c6
06e9724
61c5c3c
6330f8b
927a4d2
8d6eef6
27c8912
2673211
2850fc4
a0a76d2
b12a752
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -227,7 +227,8 @@ jobs: | |||||||||||||||
| - name: Check if pre-release | ||||||||||||||||
| if: inputs.pre_release | ||||||||||||||||
| run: | | ||||||||||||||||
| version=$(uv tree | grep 'langflow' | grep -v 'langflow-base' | awk '{print $2}' | sed 's/^v//') | ||||||||||||||||
| version="${{ inputs.release_tag }}" | ||||||||||||||||
| echo "$version" | ||||||||||||||||
| if [[ "${version}" =~ ^([0-9]+\.)?([0-9]+\.)?[0-9]+((a|b|rc|dev|post)([0-9]+))$ ]]; then | ||||||||||||||||
|
Comment on lines
+230
to
232
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: head -50 .github/workflows/release.ymlRepository: langflow-ai/langflow Length of output: 1525 🏁 Script executed: wc -l .github/workflows/release.ymlRepository: langflow-ai/langflow Length of output: 97 🏁 Script executed: sed -n '220,240p' .github/workflows/release.ymlRepository: langflow-ai/langflow Length of output: 904 🏁 Script executed: sed -n '1,100p' .github/workflows/release.ymlRepository: langflow-ai/langflow Length of output: 3474 🏁 Script executed: git tag -l | head -30Repository: langflow-ai/langflow Length of output: 46 🏁 Script executed: grep -n "release_tag\|version" .github/workflows/release.yml | head -30Repository: langflow-ai/langflow Length of output: 2056 🏁 Script executed: git log --oneline --decorate | grep tag | head -20Repository: langflow-ai/langflow Length of output: 46 🏁 Script executed: git describe --tags 2>/dev/null || echo "No tags found"Repository: langflow-ai/langflow Length of output: 77 🏁 Script executed: git show-ref --tags | head -20Repository: langflow-ai/langflow Length of output: 46 Strip the "v" prefix from release_tag before validating prerelease version format. The regex at line 232 expects a version string without a "v" prefix (e.g., Add prefix stripping before the regex check: - name: Check if pre-release
if: inputs.pre_release
run: |
version="${{ inputs.release_tag }}"
+ version="${version#v}"
echo "$version"
if [[ "${version}" =~ ^([0-9]+\.)?([0-9]+\.)?[0-9]+((a|b|rc|dev|post)([0-9]+))$ ]]; then📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| echo "Pre-release version detected. Continuing with the release." | ||||||||||||||||
| else | ||||||||||||||||
|
|
||||||||||||||||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent prerelease flag for main package in experimental tests.
Line 492 adds
--prerelease=allowfor Windows experimental main package installation, but line 534 (Unix experimental main package) does not have this flag. If the main package may depend on prerelease versions (which line 492 suggests), both platforms should have consistent flags.Apply this diff to add consistency:
WHEEL_FILE=$(find ./main-dist -name "*.whl" -type f | head -1) if [ -n "$WHEEL_FILE" ]; then - uv pip install --python ./test-env/bin/python "$WHEEL_FILE" + uv pip install --prerelease=allow --python ./test-env/bin/python "$WHEEL_FILE" else echo "No wheel file found in ./main-dist/" exit 1Also applies to: 534-534
🤖 Prompt for AI Agents