fix: update sidebar icon styles to maintain backward compatibility#10947
fix: update sidebar icon styles to maintain backward compatibility#10947viktoravelino merged 2 commits intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughExtends the SIDEBAR_CATEGORIES export in styleUtils.ts by adding sixteen new sidebar category entries (Agents, Data, Logic, Helpers, Models, Vector Stores, Inputs, Outputs, Prompts, Chains, Loaders, Link Extractors, Output Parsers, Retrievers, Text Splitters, Toolkits) after the Tools category. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (39.27%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10947 +/- ##
==========================================
- Coverage 32.94% 32.93% -0.02%
==========================================
Files 1387 1387
Lines 65338 65334 -4
Branches 9653 9653
==========================================
- Hits 21528 21520 -8
- Misses 42716 42721 +5
+ Partials 1094 1093 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/frontend/src/utils/styleUtils.ts (1)
234-249: Align new sidebar category metadata with existing icon/color mappingsNew categories and icons look consistent overall with existing usage, but a couple of small alignment points are worth checking:
Promptsusesicon: "braces"whilecategoryIcons.promptsandnodeIconToDisplayIconMap.promptsuse"Braces". Resolution will still work viagetLucideIconName, but using the same casing everywhere ("Braces") would keep icon naming consistent.Logicis introduced here (name: "logic") but there is no corresponding entry for"logic"innodeColors,nodeColorsName, orcategoryIcons/nodeIconToDisplayIconMapin this file. Iflogicwill be used as a node/category key elsewhere (for colors or icon lookup), consider adding matching entries; if it’s only a UI grouping label, this is fine as is.Can you confirm whether you want
Promptsto standardize on"Braces"and whetherlogicneeds color/icon mappings, or is purely cosmetic in the sidebar? Based on learnings, icon names should stay consistent across mappings.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/frontend/src/utils/styleUtils.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
src/frontend/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
src/frontend/src/**/*.{ts,tsx}: Use React 18 with TypeScript for frontend development
Use Zustand for state management
Files:
src/frontend/src/utils/styleUtils.ts
src/frontend/src/utils/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
Use named exports for utility functions in the utils/ directory
Files:
src/frontend/src/utils/styleUtils.ts
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-06-23T12:46:52.420Z
Learning: When implementing a new component icon in Langflow, ensure the icon name is clear, recognizable, and used consistently across both backend (Python 'icon' attribute) and frontend (React/TypeScript mapping).
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-11-24T19:46:26.770Z
Learning: Applies to docs/sidebars.js : Sidebar configuration in sidebars.js must use category types to organize documentation into logical sections
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/src/utils/**/*.{ts,tsx} : Use named exports for utility functions in the utils/ directory
📚 Learning: 2025-11-24T19:46:26.770Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-11-24T19:46:26.770Z
Learning: Applies to docs/sidebars.js : Sidebar configuration in sidebars.js must use category types to organize documentation into logical sections
Applied to files:
src/frontend/src/utils/styleUtils.ts
📚 Learning: 2025-11-24T19:46:45.790Z
Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/frontend_development.mdc:0-0
Timestamp: 2025-11-24T19:46:45.790Z
Learning: Applies to src/frontend/src/utils/**/*.{ts,tsx} : Use named exports for utility functions in the utils/ directory
Applied to files:
src/frontend/src/utils/styleUtils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test Starter Templates
- GitHub Check: Run Frontend Unit Tests / Frontend Jest Unit Tests
- GitHub Check: Test Docker Images / Test docker images
This pull request expands the list of sidebar categories in the
SIDEBAR_CATEGORIESarray insrc/frontend/src/utils/styleUtils.ts. The update introduces several new categories, each with a display name, internal name, and associated icon, which will help organize and visually distinguish different types of items in the sidebar.New sidebar categories added:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.