-
Notifications
You must be signed in to change notification settings - Fork 8.2k
fix: mcp-proxy process leak #10988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: mcp-proxy process leak #10988
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
271a230
fix leak
phact 3330537
[autofix.ci] apply automated fixes
autofix-ci[bot] b31d8c9
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] 8161a6e
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] cf2b417
Merge branch 'main' into fix-mcp-proxy-process-leak
edwinjosechittilappilly 0943672
[autofix.ci] apply automated fixes
autofix-ci[bot] 55ca4a0
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] c581ba1
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] 6a86414
Move MCP client imports out of loop iteration in get_servers (#10993)
Copilot ebe11ac
[autofix.ci] apply automated fixes
autofix-ci[bot] 647ad2f
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] 75d9a66
Merge branch 'main' into fix-mcp-proxy-process-leak
Adam-Aghili 248794e
[autofix.ci] apply automated fixes
autofix-ci[bot] 8722a2a
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] afb25ad
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] 8683731
Merge branch 'main' into fix-mcp-proxy-process-leak
Adam-Aghili 227cc95
[autofix.ci] apply automated fixes
autofix-ci[bot] 4e69254
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] fae2360
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] 2fc6cc1
Merge branch 'main' into fix-mcp-proxy-process-leak
Adam-Aghili 5691b1a
[autofix.ci] apply automated fixes
autofix-ci[bot] 03f8f60
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] 87d54c9
[autofix.ci] apply automated fixes (attempt 3/3)
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I say we get this in for v1.7.
Let's add a follow up to the
update_toolsfunction that reminds us to refactor how it creates clients, so nobody can call it in the future without cleanup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point Jordan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot can you think of a clean refactor where it cleans up after itself?