Refactor update_tools to use context manager for automatic cleanup #10994
+130
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_toolsfunction creates MCP clients but requires callers to manually manage cleanup, leading to verbose finally blocks and potential for resource leaks.Changes
MCPToolsManagercontext manager: Encapsulates client creation, tool fetching, and automatic cleanup on exitupdate_tools_with_cleanup()factory function: Returns configured context manager instanceget_serversendpoint: Replaced manual client management with context manager patternBefore/After
Before:
After:
The original
update_toolsfunction remains unchanged for backward compatibility with components that manage client lifecycle externally (e.g.,MCPToolsComponent).💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.