Skip to content

Conversation

@anovazzi1
Copy link
Contributor

No description provided.

@anovazzi1 anovazzi1 closed this Feb 14, 2023
@anovazzi1 anovazzi1 deleted the consumingApi branch February 14, 2023 19:35
@anovazzi1 anovazzi1 restored the consumingApi branch February 14, 2023 19:35
@ibiscp ibiscp deleted the consumingApi branch February 28, 2023 23:31
nicoloboschi added a commit to nicoloboschi/langflow that referenced this pull request May 31, 2024
* deps: use base 0.0.1

* commit lock
rodrigosnader added a commit that referenced this pull request Sep 27, 2025
…e compatibility

This commit fixes two critical bugs that completely broke Agent memory in the main branch:

## Bug #1: Inheritance Method Call Error
- Fixed incorrect method calls in Agent component inheritance
- Changed `get_base_inputs()` to `_base_inputs` in:
  - src/lfx/src/lfx/components/agents/agent.py:157
  - src/lfx/src/lfx/base/agents/agent.py:229

## Bug #2: Message Type Incompatibility
- Fixed type checking in Agent base class to handle both Message types
- Memory returns `langflow.schema.message.Message` but Agent expected `lfx.schema.message.Message`
- Updated type check to use duck typing instead of strict isinstance check
- Changed in src/lfx/src/lfx/base/agents/agent.py:148-150

## Impact
- Agents can now remember conversation context across messages
- Memory functionality restored to same level as release-1.6.0
- Fixes issue where agents would forget user information immediately

## Test Results
- Before: Agent says "I don't have access to your name or occupation"
- After: Agent says "Your name is VICTORY TEST, and you work as a memory bug hunter"

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 29, 2025
…e compatibility (#10008)

* fix: Restore Agent memory functionality by fixing inheritance and type compatibility

This commit fixes two critical bugs that completely broke Agent memory in the main branch:

## Bug #1: Inheritance Method Call Error
- Fixed incorrect method calls in Agent component inheritance
- Changed `get_base_inputs()` to `_base_inputs` in:
  - src/lfx/src/lfx/components/agents/agent.py:157
  - src/lfx/src/lfx/base/agents/agent.py:229

## Bug #2: Message Type Incompatibility
- Fixed type checking in Agent base class to handle both Message types
- Memory returns `langflow.schema.message.Message` but Agent expected `lfx.schema.message.Message`
- Updated type check to use duck typing instead of strict isinstance check
- Changed in src/lfx/src/lfx/base/agents/agent.py:148-150

## Impact
- Agents can now remember conversation context across messages
- Memory functionality restored to same level as release-1.6.0
- Fixes issue where agents would forget user information immediately

## Test Results
- Before: Agent says "I don't have access to your name or occupation"
- After: Agent says "Your name is VICTORY TEST, and you work as a memory bug hunter"

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* fix: Update data_to_messages function to accept both Data and Message types

This commit modifies the `data_to_messages` function to accept a list of both `Data` and `Message` types, enhancing type compatibility. The function's docstring has been updated to reflect the new input type and return type, ensuring clarity in its usage.

* fix: improve message validation in Agent

This commit updates the chat history processing in the LCAgentComponent to ensure that only messages with valid 'text' data are included. The method now checks for the presence of 'text' in the message data before converting it to the appropriate format. Additionally, the base input retrieval method has been changed from `_base_inputs` to `get_base_inputs()` for consistency and clarity.

* fix: enhance chat history validation to support Data type

* fix: improve input handling to support dynamic message conversion

---------

Co-authored-by: Claude <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Edwin Jose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant