Skip to content

Conversation

@jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Jul 6, 2025

The run_until_complete function was incorrectly trying to call loop.run_until_complete() on an already running event loop, which causes EventLoopBlockError.

This PR updates the function to run coroutines in a new thread with a separate event loop. That said, this is done for all component executions, so there may be overhead in creating a new thread for component execution.

ogabrielluiz and others added 4 commits July 2, 2025 16:46
- Updated langflow version to 1.5.0 in pyproject.toml, package.json, and package-lock.json.
- Updated langflow-base dependency to version 0.5.0.
- Added platform markers for several dependencies in uv.lock to improve compatibility across different systems.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 6, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-coroutine-in-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jordanrfrazier jordanrfrazier changed the base branch from main to release-1.5.0 July 6, 2025 21:39
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 6, 2025
…tements and improve exception handling in coroutines.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 7, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 7, 2025
@ogabrielluiz ogabrielluiz merged commit 9f689ec into release-1.5.0 Jul 7, 2025
66 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-coroutine-in-tests branch July 7, 2025 13:30
ogabrielluiz added a commit that referenced this pull request Jul 8, 2025
…ailures (#8890)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
fix: fixes auth check for auto_login  (#8796)
ogabrielluiz added a commit that referenced this pull request Jul 8, 2025
…ailures (#8890)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
fix: fixes auth check for auto_login  (#8796)
ogabrielluiz added a commit that referenced this pull request Jul 8, 2025
…ailures (#8890)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
fix: fixes auth check for auto_login  (#8796)
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Jul 10, 2025
…ailures (langflow-ai#8890)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
fix: fixes auth check for auto_login  (langflow-ai#8796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants