-
Notifications
You must be signed in to change notification settings - Fork 8.2k
docs: langflow 1.5 auto-login security doc #9057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new section has been added to the SECURITY.md file, detailing a known authentication bypass vulnerability affecting Langflow versions prior to 1.5.0. The update describes the issue, its impact, and remediation steps, and references relevant documentation for further information. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
SECURITY.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-23T12:46:29.953Z
Learning: When writing documentation for Langflow using Docusaurus, always use professional but approachable tone, second person voice for instructions, and present tense for current features.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.682Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use consistent terminology: always capitalize 'Langflow', 'Component', and 'Flow' when referring to Langflow concepts; always uppercase 'API' and 'JSON'.
SECURITY.md
Outdated
| In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication. | ||
| In this case, API requests don't require a Langflow API key. | ||
|
|
||
| To address, upgrade to >= 1.5.0. | ||
|
|
||
| For more information, see [Authentication](https://docs.langflow.org/configuration-authentication). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Tighten wording & spell out the exact pre-conditions
- Mention that the issue only manifests when BOTH
LANGFLOW_AUTO_LOGIN=trueand authentication is enabled (LANGFLOW_AUTH_LOGIN=true), mirroring the behaviour fixed in 1.5.0. - Keep tense/voice consistent with the rest of the document (“Present tense, second-person” per docs guidelines).
- Avoid the contraction “don’t” in technical docs.
-In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication.
-In this case, API requests don't require a Langflow API key.
+In Langflow versions earlier than 1.5.0, when `LANGFLOW_AUTO_LOGIN=true` **and** authentication is enabled (`LANGFLOW_AUTH_LOGIN=true`), Langflow automatically logs the user in as a superuser without prompting for credentials.
+As a result, API requests do not require a Langflow API key.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication. | |
| In this case, API requests don't require a Langflow API key. | |
| To address, upgrade to >= 1.5.0. | |
| For more information, see [Authentication](https://docs.langflow.org/configuration-authentication). | |
| In Langflow versions earlier than 1.5.0, when `LANGFLOW_AUTO_LOGIN=true` **and** authentication is enabled (`LANGFLOW_AUTH_LOGIN=true`), Langflow automatically logs the user in as a superuser without prompting for credentials. | |
| As a result, API requests do not require a Langflow API key. | |
| To address, upgrade to >= 1.5.0. | |
| For more information, see [Authentication](https://docs.langflow.org/configuration-authentication). |
🤖 Prompt for AI Agents
In SECURITY.md around lines 55 to 60, clarify that the security issue occurs
only when both LANGFLOW_AUTO_LOGIN=true and LANGFLOW_AUTH_LOGIN=true are set,
reflecting the exact pre-conditions fixed in version 1.5.0. Rewrite the text to
use present tense and second-person voice consistently, and replace contractions
like "don't" with full forms such as "do not" to maintain a formal technical
tone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
SECURITY.md (2)
53-53: Capitalize “Fixed” for consistency with prior headingsThe earlier section uses “(Fixed in 1.3.0)”. Staying consistent helps readers skim quickly.
-### No API key required if running Langflow with `LANGFLOW_AUTH_LOGIN=true` (fixed in 1.5.0) +### No API key required if running Langflow with `LANGFLOW_AUTH_LOGIN=true` (Fixed in 1.5.0)
58-60: Add a severity indicator and CVE/reference if availableFor security docs, stating a CVSS score or at least “Severity: High” (plus a CVE ID when issued) helps downstream consumers triage.
aimurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible typo in the header otherwise lgtm
|
Build successful! ✅ |
|
Build successful! ✅ |
|
Build successful! ✅ |
|
Build successful! ✅ |
* langflow-auto-login-security-doc * trailing-space * auto-not-auth * clarify-new-behavior * env-var-default * security-md-and-var-names * Apply suggestions from code review * Update docs/docs/Configuration/environment-variables.mdx * Update docs/docs/Configuration/configuration-authentication.mdx --------- Co-authored-by: April I. Murphy <[email protected]>
* langflow-auto-login-security-doc * trailing-space * auto-not-auth * clarify-new-behavior * env-var-default * security-md-and-var-names * Apply suggestions from code review * Update docs/docs/Configuration/environment-variables.mdx * Update docs/docs/Configuration/configuration-authentication.mdx --------- Co-authored-by: April I. Murphy <[email protected]>
Update the security notice so end users understand that they need to update to 1.5.0 if they're using the default behavior of auto_login=true.
Summary by CodeRabbit