Skip to content

Conversation

@mendonk
Copy link
Collaborator

@mendonk mendonk commented Jul 15, 2025

Update the security notice so end users understand that they need to update to 1.5.0 if they're using the default behavior of auto_login=true.

Summary by CodeRabbit

  • Documentation
    • Added details about a known authentication bypass vulnerability affecting versions prior to 1.5.0, including mitigation steps and references to official documentation.

@mendonk mendonk requested review from aimurphy and ogabrielluiz July 15, 2025 16:15
@mendonk mendonk self-assigned this Jul 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new section has been added to the SECURITY.md file, detailing a known authentication bypass vulnerability affecting Langflow versions prior to 1.5.0. The update describes the issue, its impact, and remediation steps, and references relevant documentation for further information.

Changes

File(s) Change Summary
SECURITY.md Added a new section describing an authentication bypass vulnerability and mitigation guidance.

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • mendonk
  • jordanrfrazier
  • aimurphy
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs-security-notice-recommendation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 15, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d829113 and 9522276.

📒 Files selected for processing (1)
  • SECURITY.md (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-23T12:46:29.953Z
Learning: When writing documentation for Langflow using Docusaurus, always use professional but approachable tone, second person voice for instructions, and present tense for current features.
Learnt from: CR
PR: langflow-ai/langflow#0
File: .cursor/rules/docs_development.mdc:0-0
Timestamp: 2025-06-30T14:40:02.682Z
Learning: Applies to docs/docs/**/*.{md,mdx} : Use consistent terminology: always capitalize 'Langflow', 'Component', and 'Flow' when referring to Langflow concepts; always uppercase 'API' and 'JSON'.

SECURITY.md Outdated
Comment on lines 55 to 60
In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication.
In this case, API requests don't require a Langflow API key.

To address, upgrade to >= 1.5.0.

For more information, see [Authentication](https://docs.langflow.org/configuration-authentication).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Tighten wording & spell out the exact pre-conditions

  1. Mention that the issue only manifests when BOTH LANGFLOW_AUTO_LOGIN=true and authentication is enabled (LANGFLOW_AUTH_LOGIN=true), mirroring the behaviour fixed in 1.5.0.
  2. Keep tense/voice consistent with the rest of the document (“Present tense, second-person” per docs guidelines).
  3. Avoid the contraction “don’t” in technical docs.
-In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication.
-In this case, API requests don't require a Langflow API key.
+In Langflow versions earlier than 1.5.0, when `LANGFLOW_AUTO_LOGIN=true` **and** authentication is enabled (`LANGFLOW_AUTH_LOGIN=true`), Langflow automatically logs the user in as a superuser without prompting for credentials.
+As a result, API requests do not require a Langflow API key.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
In Langflow versions earlier than 1.5.0, if `LANGFLOW_AUTO_LOGIN` is set to `true`, Langflow automatically logs users in as a superuser without requiring authentication.
In this case, API requests don't require a Langflow API key.
To address, upgrade to >= 1.5.0.
For more information, see [Authentication](https://docs.langflow.org/configuration-authentication).
In Langflow versions earlier than 1.5.0, when `LANGFLOW_AUTO_LOGIN=true` **and** authentication is enabled (`LANGFLOW_AUTH_LOGIN=true`), Langflow automatically logs the user in as a superuser without prompting for credentials.
As a result, API requests do not require a Langflow API key.
To address, upgrade to >= 1.5.0.
For more information, see [Authentication](https://docs.langflow.org/configuration-authentication).
🤖 Prompt for AI Agents
In SECURITY.md around lines 55 to 60, clarify that the security issue occurs
only when both LANGFLOW_AUTO_LOGIN=true and LANGFLOW_AUTH_LOGIN=true are set,
reflecting the exact pre-conditions fixed in version 1.5.0. Rewrite the text to
use present tense and second-person voice consistently, and replace contractions
like "don't" with full forms such as "do not" to maintain a formal technical
tone.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 15, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
SECURITY.md (2)

53-53: Capitalize “Fixed” for consistency with prior headings

The earlier section uses “(Fixed in 1.3.0)”. Staying consistent helps readers skim quickly.

-### No API key required if running Langflow with `LANGFLOW_AUTH_LOGIN=true` (fixed in 1.5.0)
+### No API key required if running Langflow with `LANGFLOW_AUTH_LOGIN=true` (Fixed in 1.5.0)

58-60: Add a severity indicator and CVE/reference if available

For security docs, stating a CVSS score or at least “Severity: High” (plus a CVE ID when issued) helps downstream consumers triage.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d829113 and 9522276.

📒 Files selected for processing (1)
  • SECURITY.md (1 hunks)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 15, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 15, 2025
Copy link
Collaborator

@aimurphy aimurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible typo in the header otherwise lgtm

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 17, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 23, 2025
@mendonk mendonk requested a review from jordanrfrazier July 23, 2025 13:36
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@mendonk mendonk added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit d59c890 Jul 23, 2025
13 checks passed
@mendonk mendonk deleted the docs-security-notice-recommendation branch July 23, 2025 14:01
lucaseduoli pushed a commit that referenced this pull request Jul 24, 2025
* langflow-auto-login-security-doc

* trailing-space

* auto-not-auth

* clarify-new-behavior

* env-var-default

* security-md-and-var-names

* Apply suggestions from code review

* Update docs/docs/Configuration/environment-variables.mdx

* Update docs/docs/Configuration/configuration-authentication.mdx

---------

Co-authored-by: April I. Murphy <[email protected]>
2getsandesh pushed a commit to 2getsandesh/langflow-IBM that referenced this pull request Aug 6, 2025
* langflow-auto-login-security-doc

* trailing-space

* auto-not-auth

* clarify-new-behavior

* env-var-default

* security-md-and-var-names

* Apply suggestions from code review

* Update docs/docs/Configuration/environment-variables.mdx

* Update docs/docs/Configuration/configuration-authentication.mdx

---------

Co-authored-by: April I. Murphy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants