Fix/clean data chat output #9789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughRenames the MCP composer env flag and adjusts Windows scripts; bumps version and pins dependencies. Adds MCP Composer orchestration, DB-backed API-key auth, and related endpoints. Refactors knowledge-base components and exports. Updates Docling/file handling and message/memory behaviors. Removes deprecated tools/components. Changes various UI labels and provider constants. Updates docs defaults. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant API as Projects API
participant AH as handle_auth_settings_update
participant S as Settings/Services
participant MC as MCPComposerService
participant DB as DB
U->>API: PATCH /projects/{id} (auth_settings, ... )
API->>DB: Load project
API->>AH: handle_auth_settings_update(project, new_auth_settings)
AH-->>API: { should_start, should_stop, should_handle }
API->>DB: Save updated project/auth_settings
alt should_start
API->>MC: register_project_with_composer(project) (bg task)
MC-->>API: ack
else should_stop
API->>MC: stop_project_composer(project_id)
MC-->>API: ack
end
API-->>U: 200 Updated
sequenceDiagram
autonumber
participant C as Client
participant API as MCP Projects API
participant DB as DB
participant K as API Key Store
participant M as MCP Composer
C->>API: GET /projects/{id}/composer_url (auth)
API->>DB: verify_project_access(user, project)
API->>DB: verify_project_auth(db, project_id, key/query/header)
DB->>K: check_key(project_id, key)
K-->>DB: user or error
alt uses composer
API->>M: get_or_start_mcp_composer(config, name, id)
M-->>API: running
API-->>C: 200 { sse_url, uses_composer: true }
else not using composer
API-->>C: 200 { uses_composer: false }
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces the clean_data input that was accidentally removed in PR #9610.
Summary by CodeRabbit