-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Fix: Corrects 404 error with MCP when a reverse proxy adds a base path #9804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
striver-24
wants to merge
76
commits into
langflow-ai:main
Choose a base branch
from
striver-24:fix/mcp-basepath-404
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
3eb7cd6
Update pyproject versions
jordanrfrazier cc975df
fix: Avoid namespace collision for Astra (#9544)
erichare e423526
fix: Revert to a working composio release for module import (#9569)
erichare 7fec73d
fix: Knowledge base component refactor (#9543)
erichare d8b5731
fix: Fix env file handling in Windows build scripts (#9414)
Cristhianzl 49ddc8c
fix: update agent_llm display name to "Model Provider" in AgentCompon…
edwinjosechittilappilly e494afb
fix: use custom file handler on chat view, disable mcp_composer by de…
lucaseduoli 48fe917
fix: Use the newest file component in Vector Store RAG Template (#9571)
erichare 45512a5
fix: AI/ML icon is missing (#9553)
deon-sanchez d38e8f4
fix: Allow updates to the file component in templates using it (#9572)
erichare 7a4bcfb
fix: Fixes filtering so legacy components aren't shown by default (#9…
mfortman11 e07d489
fix: changed name on tool mode to slug, added close button to sidebar…
lucaseduoli 9e871e2
fix: enhance scroll behavior on playground (#9586)
lucaseduoli f792525
fix: delete duplicate Serper api from google bundle (#9601)
lucaseduoli d9c005b
fix: allow deletion of mcp servers, add tests for mcp sidebar (#9587)
lucaseduoli 5860a8b
fix: change zoom in and out limit, create tests for zooming in and ou…
lucaseduoli f82e514
fix: Add localStorage persistence for feature toggles (#9597)
Cristhianzl b4e4435
fix: Add help text to Lock Flow option (#9600)
Cristhianzl 2c21fbd
fix: Add comprehensive tests and improve minimal condition logic (#9611)
Cristhianzl 133fe6c
fix: change icon color for mcp, remove color setting of icons (#9594)
lucaseduoli d715fa1
fix: remove unsupported styling options from chats components (#9610)
italojohnny 9798500
fix: disable mcp auto install for not installed applications, refacto…
lucaseduoli 349295a
fix: Properly allow the non-specification of an OCR Engine (#9617)
erichare dfd4037
fix: Support objects with data attribute in body processing (#9644)
Cristhianzl f8da854
fix: Add comprehensive message sorting + tests (#9641)
Cristhianzl cfd10f8
fix: Fix audio recording resource cleanup (#9623)
Cristhianzl f854b70
fix: Add voice mode availability detection (#9621)
Cristhianzl 8b0ddde
fix: Remove formatting from agent input text content (#9638)
Cristhianzl 9f09250
fix: added most important types at the beginning of the extensions ar…
lucaseduoli 8d26d52
fix: Include flow ID in webhook URLs (#9624)
Cristhianzl 169fd32
fix(logger): add optional cache to configure; update caching behavior…
ogabrielluiz d10854a
fix: Update sidebar border styles (#9625)
mfortman11 a290c46
fix: Remove top padding from sidebar groups (#9636)
Cristhianzl ea49ead
fix: disable message editing on playground, fix new session not persi…
lucaseduoli 9d04d56
fix: disable elevate edges on node select (#9658)
lucaseduoli e61cb46
fix: Properly respect the order parameter for Message History (#9605)
erichare e20ff66
fix: Return multi-row dataframe when Structured Output data supports …
erichare 68288aa
fix: apply to fields in settings page (#9602)
edwinjosechittilappilly 617e94b
fix: Segmented Sidebar switch to search on value change (#9615)
mfortman11 d1998b3
fix: deprecate claude 3 sonnet model (#9622)
edwinjosechittilappilly 375e672
fix: Properly import Langchain ToolMessage for Message options (#9675)
erichare 032c7fa
fix: fixed user settings test (#9690)
lucaseduoli bc13c5b
fix: Remove warning log for unset TRACELOOP_API_KEY in configuration …
ogabrielluiz 57686a7
fix: knowledge base fixes for 1.6 pointing to release branch (#9683)
deon-sanchez 320cd00
fix: remove github link on discord button (#9655)
lucaseduoli d9a97cc
fix: remove python code component, fix placeholder not appearing (#9660)
lucaseduoli f51575e
fix: add margins to <p> tag in markdown (#9656)
lucaseduoli bf32bdd
fix: delete unused components, delete [deprecated] tag on the compone…
lucaseduoli 74952e8
fix: Ensure correct Docling Remote URL for API (#9708)
erichare 5687903
feat: remove agent dual output (#9700)
edwinjosechittilappilly 3b7601f
refactor: Agent component enhancements for release v1.6 (#9685)
deon-sanchez b551b0c
feat: mcp composer integration (#9506)
jordanrfrazier f2f6129
fix: Adjust padding and layout for improved spacing (#9711)
Cristhianzl 2f9dc00
fix: remove Groq from Agents model provider list (#9616)
edwinjosechittilappilly 06e00c6
fix: conditional scheduling logic to not run branch (#9722)
jordanrfrazier 1c262de
fix: disable keys when flow is locked (#9726)
lucaseduoli cf08d19
fix: superuser credential handling and AUTO_LOGIN security (#9542)
edwinjosechittilappilly 6cabf2a
chore: Update version to 1.6.0 in package files (#9746)
ogabrielluiz d9c4802
fix: update logs position to be absolute (#9724)
lucaseduoli 8cddf6c
fix: make entire playground chat area be clickable (#9721)
lucaseduoli 86815cb
fix: Restore old description from file description. (#9752)
erichare 5a8f988
fix: Preserve flows and components during project updates (#9750)
Cristhianzl c8e1efb
fix(langwatch): prevent trace errors with proper API key validation (…
italojohnny eed7a87
fix(URLComponent): filter out `None` in headers to avoid silent seria…
ogabrielluiz 4bba723
fix: put knowledge bases under feature flag (#9749)
lucaseduoli ecd7214
refactor: Padding misaligned for sidebar icons and other issues fix f…
deon-sanchez b09964e
fix: Updated Agent Starter Projects with new Templates (#9772)
deon-sanchez 17cb077
fix: remove agents from skipped components list in setup (#9785)
edwinjosechittilappilly a91ff1e
fix: improve error handling for missing OCR dependencies (#9753)
italojohnny 938542b
fix: adjust casing on Add MCP Server buttons (#9774)
lucaseduoli 56f4abc
fix: set gpt4.1 as default model (#9780)
edwinjosechittilappilly b0124e8
feat: double clicking a component will add it to the canvas (#9730)
deon-sanchez d77c802
docs: update support documentation to reflect support rebranding (#9538)
mendonk 2b329d3
Fix: Corrects 404 error with MCP when a reverse proxy adds a base path
striver-24 fc555e6
Fix: Addressed SonarCloud quality gate issues
striver-24 133326e
Fix: Addressed SonarCloud quality gate issues
striver-24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Knowledge base component refactor (#9543)
* fix: Knowledge base component refactor * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * Update styleUtils.ts * Update ingestion.py * [autofix.ci] apply automated fixes * Fix ingestion of df * [autofix.ci] apply automated fixes * Update Knowledge Ingestion.json * Fix one failing test * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * Revert composio versions for CI * Revert "Revert composio versions for CI" This reverts commit 9bcb694. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Edwin Jose <edwin.jose@datastax.com> Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
Empty file.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/backend/base/langflow/components/knowledge_bases/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| from langflow.components._importing import import_mod | ||
|
|
||
| if TYPE_CHECKING: | ||
| from langflow.components.knowledge_bases.ingestion import KnowledgeIngestionComponent | ||
| from langflow.components.knowledge_bases.retrieval import KnowledgeRetrievalComponent | ||
|
|
||
| _dynamic_imports = { | ||
| "KnowledgeIngestionComponent": "ingestion", | ||
| "KnowledgeRetrievalComponent": "retrieval", | ||
| } | ||
|
|
||
| __all__ = ["KnowledgeIngestionComponent", "KnowledgeRetrievalComponent"] | ||
|
|
||
|
|
||
| def __getattr__(attr_name: str) -> Any: | ||
| """Lazily import input/output components on attribute access.""" | ||
| if attr_name not in _dynamic_imports: | ||
| msg = f"module '{__name__}' has no attribute '{attr_name}'" | ||
| raise AttributeError(msg) | ||
| try: | ||
| result = import_mod(attr_name, _dynamic_imports[attr_name], __spec__.parent) | ||
| except (ModuleNotFoundError, ImportError, AttributeError) as e: | ||
| msg = f"Could not import '{attr_name}' from '{__name__}': {e}" | ||
| raise AttributeError(msg) from e | ||
| globals()[attr_name] = result | ||
| return result | ||
|
|
||
|
|
||
| def __dir__() -> list[str]: | ||
| return list(__all__) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2207,7 +2207,7 @@ | |
| }, | ||
| { | ||
| "name": "langchain_core", | ||
| "version": "0.3.72" | ||
| "version": "0.3.75" | ||
| }, | ||
| { | ||
| "name": "langflow", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify the embeddings UI behavior.
The info text states "Only applicable if 'Include Metadata' is enabled" but the code at lines 250-251 doesn't enforce this dependency - embeddings can be included even when metadata is false.
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 5089
Enforce
include_embeddingsdependency oninclude_metadataThe component currently lets embeddings be returned even when metadata is disabled. Update
src/backend/base/langflow/components/knowledge_bases/retrieval.pyto either disable/hide the “Include Embeddings” toggle unless “Include Metadata” is true or wrap the_embeddingsassignment in a guard that checks bothself.include_metadataandself.include_embeddings.🤖 Prompt for AI Agents