-
Notifications
You must be signed in to change notification settings - Fork 8.2k
refactor: update lfx directory structure for improved developer experience #9833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
2b9c7c6
703a9e0
43a1cc1
7a6e6aa
b7aa24d
34e8198
7e79964
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -89,9 +89,9 @@ jobs: | |||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| uv lock | ||||||||||||||||||||||||||||||||
| cd src/backend/base && uv lock && cd ../../.. | ||||||||||||||||||||||||||||||||
| cd src/lfx && uv lock && cd ../.. | ||||||||||||||||||||||||||||||||
| cd src/core && uv lock && cd ../.. | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| git add pyproject.toml src/backend/base/pyproject.toml src/lfx/pyproject.toml uv.lock src/backend/base/uv.lock | ||||||||||||||||||||||||||||||||
| git add pyproject.toml src/backend/base/pyproject.toml src/core/pyproject.toml uv.lock src/backend/base/uv.lock | ||||||||||||||||||||||||||||||||
| git commit -m "Update version and project name" | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include src/core/uv.lock in commit to avoid lockfile drift You run Apply this diff: - git add pyproject.toml src/backend/base/pyproject.toml src/core/pyproject.toml uv.lock src/backend/base/uv.lock
+ git add pyproject.toml src/backend/base/pyproject.toml src/core/pyproject.toml \
+ uv.lock src/backend/base/uv.lock src/core/uv.lock📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||
| echo "Tagging main with $MAIN_TAG" | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add src/core/uv.lock to the commit.
You run uv lock inside src/core but don’t stage src/core/uv.lock. This can desync the committed lockfiles.
Apply:
Also applies to: 94-95
🤖 Prompt for AI Agents