Fix: the pict type picture was not processed in the docx #19305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
crazywoola
reviewed
May 7, 2025
crazywoola
requested changes
May 7, 2025
Member
crazywoola
left a comment
crazywoola
left a comment
There was a problem hiding this comment.
Please do not modify the PR template, and link an existing issue in the desciption.
Contributor
Author
The comments have been modified to English, and there are no entries in the issue that exist. This modification is relatively simple. It is to add support for pict type images when processing docx. |
Member
|
Please fix the lint errors. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances parse_paragraph to correctly extract VML-based pict images and prevents duplicate processing when both drawing and pict tags are present.
- Introduce a
has_drawingflag to skip pict extraction if a drawing has already been processed - Add handling for
<w:pict>shapes by looking upbinDataand VMLimagedatarelationships - Ensure pict images are appended only when they exist in
image_map
Comments suppressed due to low confidence (2)
api/core/rag/extractor/word_extractor.py:261
- No tests appear to cover VML-based pict extraction. Add a unit test with a
.docxcontaining a<w:pict>shape to ensure this code path is exercised.
shape_elements = run.element.findall(
api/core/rag/extractor/word_extractor.py:266
- Verify that the
{http://schemas.openxmlformats.org/wordprocessingml/2006/main}binDatanamespace is correct for VML pict elements—in some docsbinDatamay reside in a different namespace or part.
shape_image = shape.find(
crazywoola
approved these changes
Jul 17, 2025
tutkun
pushed a commit
to tutkun/dify
that referenced
this pull request
Aug 15, 2025
…19305) Co-authored-by: zqgame <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: the pict type picture was not processed in the docx