Skip to content

fix: plugin deamon start fail #21841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crazywoola merged 3 commits into from
Jul 3, 2025
Merged

fix: plugin deamon start fail #21841

crazywoola merged 3 commits into from
Jul 3, 2025

Conversation

@fdb02983rhy
Copy link
Contributor

@fdb02983rhy fdb02983rhy commented Jul 2, 2025 •
edited by crazywoola
Loading

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #21840

Screenshots

CleanShot 2025-07-02 at 21 10 07@2x

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@fdb02983rhy
Set default S3_USE_AWS to false in compose file
3ee2ce4 
Updated the docker-compose.yaml to default the S3_USE_AWS environment variable to 'false' if not set, ensuring consistent behavior when the variable is unset.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 2, 2025
crazywoola
crazywoola reviewed Jul 2, 2025
View reviewed changes
@fdb02983rhy
Revert "Set default S3_USE_AWS to false in compose file"
5c2a9e5 
This reverts commit 3ee2ce4.
@fdb02983rhy
Set default S3_USE_AWS to false in compose files
4c4c6e3 
Updated both docker-compose-template.yaml and docker-compose.yaml to set the default value of S3_USE_AWS to 'false' instead of an empty string. This ensures consistent and explicit default behavior for S3 usage configuration.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2025
@crazywoola crazywoola merged commit daab648 into langgenius:main Jul 3, 2025
8 checks passed
This was referenced Jul 4, 2025
Closed
Closed
yijiaquan pushed a commit to yijiaquan/dify that referenced this pull request Jul 9, 2025
@fdb02983rhy @yijiaquan
fix: plugin deamon start fail (langgenius#21841)
b9d3bd8 
(cherry picked from commit daab648)
@Mairuis Mairuis mentioned this pull request Jul 10, 2025
Merged
@dosubot dosubot bot mentioned this pull request Jul 21, 2025
Closed
6 tasks
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
@fdb02983rhy @tutkun
fix: plugin deamon start fail (langgenius#21841)
782da88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugin deamon can not start with default setting

2 participants

@fdb02983rhy @crazywoola