-
Notifications
You must be signed in to change notification settings - Fork 18.9k
feat: Add Audio configuration setting to app configuration UI #21957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Audio configuration setting to app configuration UI #21957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new Audio configuration toggle to the app’s debug configuration UI, enabling users to upload and process audio files alongside existing Vision and Document settings.
- Introduces translation entries for the Audio feature
- Extends the debug configuration context with an
isShowAudioConfigflag - Integrates a
ConfigAudiocomponent into the main configuration panel
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web/i18n/en-US/app-debug.ts | Added audioUpload translation keys |
| web/context/debug-configuration.ts | Added isShowAudioConfig flag to context type and default |
| web/app/components/app/configuration/index.tsx | Computed isShowAudioConfig and passed it into context |
| web/app/components/app/configuration/config/index.tsx | Imported and rendered the ConfigAudio component |
| web/app/components/app/configuration/config/config-audio.tsx | Created new ConfigAudio component with toggle logic |
Comments suppressed due to low confidence (1)
web/app/components/app/configuration/config/config-audio.tsx:15
- The new
ConfigAudiocomponent lacks dedicated unit or integration tests to verify its rendering and behavior; consider adding test coverage for toggling the audio configuration.
const ConfigAudio: FC = () => {
b5e91f4 to
11bf8ea
Compare
…nius#21957) (cherry picked from commit 9a9ec0c)
Important
Fixes #<issue number>.Summary
This fixes #21956
This PR adds a new Audio configuration setting to the app configuration UI, positioned below the existing Vision and Document settings. This allows users to easily enable audio file uploads in their applications, including embedded chatbots.
Changes Made
ConfigAudiocomponent (web/app/components/app/configuration/config/config-audio.tsx) following the same pattern as existing Vision and Document configurationsisShowAudioConfigflagaudiofeature flagProblem Solved
Previously, users could not easily enable audio file uploads through the main app configuration UI. They had to work around this limitation by configuring audio uploads through user input variables, which was not intuitive. This change provides a consistent and discoverable way to enable audio file support.
Supported Audio Formats
When enabled, the following audio formats are supported:
UI Behavior
This enhancement improves the user experience by making audio file upload configuration more discoverable and consistent with other file type settings.
Screenshots
Before
After
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods