Skip to content

Conversation

@DavideDelbianco
Copy link
Contributor

@DavideDelbianco DavideDelbianco commented Jul 8, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR completes the closed #17216 adding the missing FrontEnd part
When adding a HTTP Node to your workflow the backend will send the expected default state of the switch, based on the ENV variable HTTP_REQUEST_NODE_SSL_VERIFY

Screenshots

Before After
image image

Animazione

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 📚 documentation Improvements or additions to documentation labels Jul 8, 2025
@QuantumGhost
Copy link
Collaborator

I recommend adding a warning tooltip to the "VERIFY SSL CERTIFICATE" toggle to inform users about the security implications of disabling SSL verification. The tooltip should clearly indicate that this option should only be disabled in exceptional circumstances (e.g., development/testing environments) and that disabling it in production environments poses significant security risks by making the connection vulnerable to man-in-the-middle attacks.

@DavideDelbianco
Copy link
Contributor Author

image
Something like that?

@crazywoola
Copy link
Member

image Something like that?

@DavideDelbianco Please proceed with this tooltip.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2025
@crazywoola crazywoola merged commit 1885426 into langgenius:main Jul 9, 2025
5 checks passed
@DavideDelbianco DavideDelbianco deleted the chore/ssl-verify-fe branch July 9, 2025 12:13
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation 🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable HTTP Node SSL Verification

3 participants