Skip to content

Conversation

@NeatGuyCoding
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR updates the email validation function in the EmailChangeModal component to comply with RFC 5322 standards. The change replaces the basic email regex pattern with a more comprehensive RFC 5322-compliant regex pattern and adds a length validation to ensure email addresses don't exceed 254 characters.

Changes made:

  • Updated email validation regex from a simple pattern to RFC 5322 compliant pattern
  • Added email length validation (max 254 characters) as per RFC specifications
  • Enhanced validation to support more valid email address formats including special characters allowed by RFC 5322

Motivation:
The previous email validation was too restrictive and didn't follow RFC 5322 standards, potentially rejecting valid email addresses. This update ensures better compatibility with legitimate email formats while maintaining security.

Screenshots

Before After
Basic email regex validation with limited character support RFC 5322 compliant validation with comprehensive character support and length validation

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript 💪 enhancement New feature or request labels Jul 17, 2025
@crazywoola crazywoola merged commit fafb1d5 into langgenius:main Jul 17, 2025
5 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2025
@NeatGuyCoding NeatGuyCoding deleted the feat-rfc-5322 branch July 17, 2025 07:49
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants