Skip to content

Conversation

@Mairuis
Copy link
Contributor

@Mairuis Mairuis commented Jul 17, 2025

This pull request introduces several updates across multiple files, focusing on expanding tool provider management functionality, improving OAuth integration, and refining configurations. Below is a categorized summary of the most important changes:

Tool Provider Management Enhancements:

  • Added new endpoints and methods for managing built-in tool providers, including adding, updating, and deleting credentials, setting default credentials, and retrieving credential information (api/controllers/console/workspace/tool_providers.py). [1] [2] [3] [4]
  • Introduced support for custom OAuth client parameters and integrated OAuth callback handling for tool providers (api/controllers/console/workspace/tool_providers.py). [1] [2]

OAuth Integration Improvements:

  • Added the setup-system-tool-oauth-client command to configure OAuth clients for system tools (api/commands.py).
  • Included new classes and methods to handle OAuth authorization flows and credential management (api/controllers/console/workspace/tool_providers.py).

Configuration Refinements:

  • Updated .env.example to use localhost instead of 127.0.0.1 for various URLs and adjusted CORS settings accordingly (api/.env.example). [1] [2]
  • Extended constants with a new UNKNOWN_VALUE placeholder (api/constants/__init__.py).

Codebase Enhancements:

  • Refactored imports across multiple files to improve readability and maintainability (api/commands.py, api/controllers/console/workspace/tool_providers.py). [1] [2] [3]

Workflow Update:

  • Updated GitHub Actions workflow to trigger on branches matching the build/** pattern (.github/workflows/build-push.yml).

Issue

close #22546

Daemon

langgenius/dify-plugin-daemon#402

Mairuis and others added 30 commits June 23, 2025 10:48
# Conflicts:
#	README.md
#	api/services/tools/builtin_tools_manage_service.py
# Conflicts:
#	api/services/plugin/oauth_service.py
# Conflicts:
#	api/core/plugin/impl/oauth.py
#	api/services/plugin/oauth_service.py
@Mairuis Mairuis requested a review from Yeuoly July 17, 2025 07:40
@Yeuoly Yeuoly marked this pull request as ready for review July 17, 2025 07:45
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Jul 17, 2025
Copy link
Contributor

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yeuoly Yeuoly merged commit a4ef900 into main Jul 17, 2025
13 checks passed
@Yeuoly Yeuoly deleted the feat/oauth branch July 17, 2025 09:18
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2025
@Mairuis Mairuis mentioned this pull request Jul 18, 2025
23 tasks
@Mairuis Mairuis changed the title Support OAuth Integration for Plugin Tools feat: support oauth for tool plugins Jul 18, 2025
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 16, 2025
@dosubot dosubot bot mentioned this pull request Aug 21, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OAuth Integration for Tools

4 participants