Skip to content

Conversation

@issac2e
Copy link
Contributor

@issac2e issac2e commented Jul 21, 2025

Summary

This PR fixes the batch size limitation error in Tencent Vector Database deletion operations by implementing batch processing logic similar to the existing add_texts method.

Issue Fixed: Resolves #22725 - ServerInternalError when deleting large numbers of vector indexes (#22725)

Context: During knowledge base document retry operations, the system attempts to delete old indexes in bulk. However, when the number of indexes exceeds the API's batch size limit (1000), it causes a server error.

Dependencies: No additional dependencies required for this change.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Jul 21, 2025
crazywoola
crazywoola previously approved these changes Jul 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 21, 2025
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 58d9297 into langgenius:main Jul 22, 2025
8 checks passed
tutkun pushed a commit to tutkun/dify that referenced this pull request Aug 15, 2025
…atch processing support (langgenius#22726)

Co-authored-by: liuchen15 <[email protected]>
Co-authored-by: crazywoola <[email protected]>
@dosubot dosubot bot mentioned this pull request Oct 17, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize tencent_vector knowledge base deletion error handling with batch processing support

2 participants