-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[5.1] Add Model::saveOrFail() to execute save operation within database transaction. #11202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -431,6 +431,34 @@ public function testEmptyMorphToRelationship() | |
| $this->assertNull($photo->imageable); | ||
| } | ||
|
|
||
| public function testSaveOrFail() | ||
| { | ||
| $date = '1970-01-01'; | ||
| $post = new EloquentTestPost([ | ||
| 'user_id' => 1, 'name' => 'Post', 'created_at' => $date, 'updated_at' => $date, | ||
| ]); | ||
|
|
||
| $this->assertTrue($post->saveOrFail()); | ||
| $this->assertEquals(1, EloquentTestPost::count()); | ||
| } | ||
|
|
||
| /** | ||
| * @expectedException Exception | ||
| */ | ||
| public function testSaveOrFailWithDuplicatedEntry() | ||
| { | ||
| $date = '1970-01-01'; | ||
| EloquentTestPost::create([ | ||
| 'id' => 1, 'user_id' => 1, 'name' => 'Post', 'created_at' => $date, 'updated_at' => $date, | ||
| ]); | ||
|
|
||
| $post = new EloquentTestPost([ | ||
| 'id' => 1, 'user_id' => 1, 'name' => 'Post', 'created_at' => $date, 'updated_at' => $date, | ||
| ]); | ||
|
|
||
| $post->saveOrFail(); | ||
| } | ||
|
|
||
| public function testMultiInsertsWithDifferentValues() | ||
| { | ||
| $date = '1970-01-01'; | ||
|
|
@@ -473,6 +501,41 @@ public function testNestedTransactions() | |
| }); | ||
| } | ||
|
|
||
| public function testNestedTransactionsUsingSaveOrFailWillSucceed() | ||
| { | ||
| $user = EloquentTestUser::create(['email' => '[email protected]']); | ||
| $this->connection()->transaction(function () use ($user) { | ||
| try { | ||
| $user->email = '[email protected]'; | ||
| $user->saveOrFail(); | ||
| } catch (Exception $e) { | ||
| // ignore the exception | ||
| } | ||
|
|
||
| $user = EloquentTestUser::first(); | ||
| $this->assertEquals('[email protected]', $user->email); | ||
| $this->assertEquals(1, $user->id); | ||
| }); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This tests follow |
||
| } | ||
|
|
||
| public function testNestedTransactionsUsingSaveOrFailWillFails() | ||
| { | ||
| $user = EloquentTestUser::create(['email' => '[email protected]']); | ||
| $this->connection()->transaction(function () use ($user) { | ||
| try { | ||
| $user->id = 'invalid'; | ||
| $user->email = '[email protected]'; | ||
| $user->saveOrFail(); | ||
| } catch (Exception $e) { | ||
| // ignore the exception | ||
| } | ||
|
|
||
| $user = EloquentTestUser::first(); | ||
| $this->assertEquals('[email protected]', $user->email); | ||
| $this->assertEquals(1, $user->id); | ||
| }); | ||
| } | ||
|
|
||
| public function testToArrayIncludesDefaultFormattedTimestamps() | ||
| { | ||
| $model = new EloquentTestUser; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for all this, just use
finallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, wait, ignore me - we don't want to always rollback, lol