Skip to content

[6.x] Backport for fix issue with polymorphic morphMaps with literal 0 (#35364) #35487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2020
Merged

[6.x] Backport for fix issue with polymorphic morphMaps with literal 0 (#35364) #35487

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abafa55
[8.x] Fix issue with polymorphic morphMaps with literal 0 (#35364)
iBotPeaches Nov 26, 2020
be8ae8b
Use setMethods for 6.x
driesvints Dec 4, 2020
a83c05b
Update HasRelationships.php
driesvints Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update HasRelationships.php
  • Loading branch information
@driesvints
driesvints authored Dec 4, 2020
commit a83c05b6aa1fde1ec875c6cc7b389843b12e8dc9
2 changes: 1 addition & 1 deletion src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public function morphTo($name = null, $type = null, $id = null, $ownerKey = null
// If the type value is null it is probably safe to assume we're eager loading
// the relationship. In this case we'll just pass in a dummy query where we
// need to remove any eager loads that may already be defined on a model.
return is_null($class = $this->{$type})
return is_null($class = $this->{$type}) || $class === ''
? $this->morphEagerTo($name, $type, $id, $ownerKey)
: $this->morphInstanceTo($class, $name, $type, $id, $ownerKey);
}
Expand Down