Skip to content

Conversation

@driesvints
Copy link
Member

@driesvints driesvints commented Feb 1, 2021

I didn't take into account that the report method can resolve dependencies from the container. This PR fixes just that.

It also fixes the incorrect return types now present on the report method's DocBlock return annotations.

Fixes #36108 #36109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViewExceptions will never be logged ViewException does not provide dependencies to the wrapped report method

4 participants