[8.x] Add perMinutes method for RateLimiting #36352
Conversation
This PR allows the `perMinute` method accept an optional argument to specify the number of decay minutes. This allows the `perMinute` method to function in the same way that the `perHour` and `perDay` methods function.
GrahamCampbell
changed the title
| * @return static | ||
| */ | ||
| public static function perMinute($maxAttempts) | ||
| public static function perMinute($maxAttempts, $decayMinutes = 1) |
There was a problem hiding this comment.
This is also a breaking change and best sent to master.
There was a problem hiding this comment.
I'm sure that I'm missing something, but I don't see how this is a breaking change? All existing code with calls to perMinute would still work properly, since the second argument is optional, wouldn't it?
There was a problem hiding this comment.
If someone if overwriting this method their implementation will break.
There was a problem hiding this comment.
Aaah, OK thanks. That makes sense.
There was a problem hiding this comment.
Thoughts on whether it would make more sense to create a new perMinutes or perCustom method instead? That wouldn't be a breaking change.
|
You can add a new |
|
Glad you agree @taylorotwell, I have created the new |
intrepidws
changed the title
4 participants
This PR allows the
perMinutemethod to accept an optional argument for the number of decay minutes. This allows theperMinutemethod to function in the same way that theperHourandperDaymethods function.